r51201 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51200‎ | r51201 | r51202 >
Date:17:48, 30 May 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Remove 'display stats only for groups as on [[page]]' on Special:LanguageStats
Modified paths:
  • /trunk/extensions/Translate/SpecialLanguageStats.php (modified) (history)
  • /trunk/extensions/Translate/Translate.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/SpecialLanguageStats.php
@@ -119,25 +119,6 @@
120120 return "\t\t" . $element . "\n";
121121 }
122122
123 - function getGroups() {
124 - $groups = wfMsgForContent( 'translate-languagestats-groups' );
125 -
126 - if( $groups ) {
127 - // Make the group names clean
128 - // Should contain one valid group name per line
129 - // All invalid group names should be ignored
130 - // Return all group names if there are no valid group names at all
131 - // FIXME: implement the above here
132 - $cleanGroups = '';
133 -
134 - if( $cleanGroups ) {
135 - return $cleanGroups;
136 - }
137 - }
138 -
139 - return MessageGroups::singleton()->getGroups();
140 - }
141 -
142123 function getBackgroundColour( $subset, $total, $fuzzy = false ) {
143124 $v = @round(255 * $subset / $total);
144125
@@ -195,7 +176,7 @@
196177 $cache = new ArrayMemoryCache( 'groupstats' );
197178
198179 # Fetch groups stats have to be displayed for
199 - $groups = $this->getGroups();
 180+ $groups = MessageGroups::singleton()->getGroups();
200181
201182 # Get statistics for the message groups
202183 foreach ( $groups as $groupName => $g ) {
Index: trunk/extensions/Translate/Translate.i18n.php
@@ -178,7 +178,7 @@
179179
180180 # Special:LanguageStats
181181 'languagestats' => 'Language statistics',
182 - 'languagestats-summary' => 'This page shows translation statistics for all ([[MediaWiki:Translate-languagestats-groups|configured]]) message groups for a language.',
 182+ 'languagestats-summary' => 'This page shows translation statistics for all message groups for a language.',
183183 'translate-language-code' => 'Language code',
184184 'translate-language-code-field-name' => 'Language code:',
185185 'translate-suppress-complete' => 'Suppress completely translated message groups',

Status & tagging log