r51196 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51195‎ | r51196 | r51197 >
Date:13:42, 30 May 2009
Author:ialex
Status:deferred
Tags:
Comment:
Tweaks for the Admin Links hook:
* changed special pages order
* code style fixes
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/Configure.func.php (modified) (history)
  • /trunk/extensions/Configure/Configure.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/CHANGELOG
@@ -1,6 +1,9 @@
22 This file lists changes on this extension.
33 Localisation updates are done on betawiki and aren't listed here.
44
 5+0.13.20 - 30 May 2009
 6+ Changed Configure special pages's order in Special:AdminLinks.
 7+
58 0.13.19 - 25 May 2009
69 * Added support for External Data, Semantic Forms, Semantic Drilldown,
710 Semantic MediaWiki and Semantic Result Formats extensions
Index: trunk/extensions/Configure/Configure.php
@@ -18,7 +18,7 @@
1919 'url' => 'http://www.mediawiki.org/wiki/Extension:Configure',
2020 'description' => 'Allow authorised users to configure the wiki via a web-based interface',
2121 'descriptionmsg' => 'configure-desc',
22 - 'version' => '0.13.19',
 22+ 'version' => '0.13.20',
2323 );
2424
2525 # Configuration part
Index: trunk/extensions/Configure/Configure.func.php
@@ -165,12 +165,12 @@
166166 * Adds links to Configure's special pages to the Special:AdminLinks page,
167167 * defined by the Admin Links extension
168168 */
169 -function efConfigureAddToAdminLinks( &$admin_links_tree ) {
170 - $general_section = $admin_links_tree->getSection(wfMsg('adminlinks_general'));
171 - $configure_row = new ALRow('configure');
172 - $configure_row->addItem(ALItem::newFromSpecialPage('Configure'));
173 - $configure_row->addItem(ALItem::newFromSpecialPage('ViewConfig'));
174 - $configure_row->addItem(ALItem::newFromSpecialPage('Extensions'));
175 - $general_section->addRow($configure_row);
 169+function efConfigureAddToAdminLinks( &$adminLinksTree ) {
 170+ $generalSection = $adminLinksTree->getSection( wfMsg( 'adminlinks_general' ) );
 171+ $configureRow = new ALRow( 'configure' );
 172+ $configureRow->addItem( ALItem::newFromSpecialPage( 'Configure' ) );
 173+ $configureRow->addItem( ALItem::newFromSpecialPage( 'Extensions' ) );
 174+ $configureRow->addItem( ALItem::newFromSpecialPage( 'ViewConfig' ) );
 175+ $generalSection->addRow( $configureRow );
176176 return true;
177177 }

Status & tagging log