r51145 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51144‎ | r51145 | r51146 >
Date:23:26, 28 May 2009
Author:dale
Status:deferred
Tags:
Comment:
fixed cortado url to "real" location: http://theora.org/cortado.jar
Modified paths:
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/mv_javaEmbed.js (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/mv_javaEmbed.js
@@ -26,7 +26,7 @@
2727 var mediaSrc = this.media_element.selected_source.getURI( this.seek_time_sec );
2828
2929 if(mediaSrc.indexOf('://')!=-1 & parseUri(document.URL).host != parseUri(mediaSrc).host){
30 - applet_loc = 'http://xiph.org/cortado.jar';
 30+ applet_loc = 'http://theora.org/cortado.jar';
3131 }else{
3232 applet_loc = mv_embed_path+'binPlayers/cortado/cortado-wmf-r46643.jar';
3333 }
@@ -73,22 +73,19 @@
7474 monitor:function(){
7575 this.getJCE()
7676 if(this.jce){
77 - try{
78 - //java reads "playtime" not ogg media time.. so add the start_offset or seek_offset
79 - //js_log(' ct: ' + this.jce.getPlayPosition() + ' so:' + this.start_offset + ' st:' + this.seek_time_sec);
80 - if(!this.start_offset)
81 - this.start_offset = 0;
82 -
83 - this.currentTime = (this.seek_time_sec==0)?
84 - this.jce.getPlayPosition() + this.start_offset :
85 - this.jce.getPlayPosition() + this.seek_time_sec ;
 77+ try{
 78+ //java reads ogg media time.. so no need to add the start or seek offset:
 79+ //js_log(' ct: ' + this.jce.getPlayPosition() + ' so:' + this.start_offset + ' st:' + this.seek_time_sec);
 80+ if(!this.start_offset)
 81+ this.start_offset = 0;
 82+ this.currentTime = this.jce.getPlayPosition();
8683 }catch (e){
8784 ///js_log('could not get time from jPlayer: ' + e);
8885 }
8986 if( this.currentTime < 0){
9087 //probably reached clip end
9188 this.onClipDone();
92 - }
 89+ }
9390 }
9491 //once currentTime is updated call parent_monitor
9592 this.parent_monitor();

Status & tagging log