r51121 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51120‎ | r51121 | r51122 >
Date:16:02, 28 May 2009
Author:dale
Status:deferred
Tags:
Comment:
fixed playlist clip representation in playhead
Modified paths:
  • /branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/mv_baseEmbed.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvPlayList.js (modified) (history)
  • /branches/new-upload/phase3/js2/mwEmbed/skins/mvpcf/styles.css (modified) (history)

Diff [purge]

Index: branches/new-upload/phase3/js2/mwEmbed/libSequencer/mvPlayList.js
@@ -803,22 +803,26 @@
804804 },
805805 //ads colors/dividers between tracks
806806 colorPlayHead: function(){
807 - if( !this.mv_seeker_width)
808 - this.mv_seeker_width = $j('#mv_play_head_'+this.id).width();
 807+ var _this = this;
 808+
 809+ if( !_this.mv_seeker_width)
 810+ _this.mv_seeker_width = $j('#mv_play_head_'+_this.id).width();
809811
810 - if( !this.track_len )
811 - this.track_len = $j('#mv_play_head_'+this.id).css('width').replace(/px/, '');
 812+ if( !_this.track_len )
 813+ _this.track_len = $j('#mv_play_head_'+_this.id).width();
812814
813815 //total duration:
814 - var pl_duration = this.getDuration();
 816+ var pl_duration = _this.getDuration();
815817
816818 var cur_pixle=0;
817819 //set up plObj
818 - var _this = this;
 820+
819821 //js_log("do play head total dur: "+pl_duration );
820 - $j.each(this.default_track.clips, function(i, clip){
821 - var perc = ( clip.getDuration() / pl_duration );
 822+ $j.each(this.default_track.clips, function(i, clip){
 823+ //(use getSoloDuration to not include transitions and such)
 824+ var perc = ( clip.getSoloDuration() / pl_duration );
822825 var pwidth = Math.round( perc * _this.track_len);
 826+ js_log('pstatus:c:'+ clip.getDuration() + ' of '+ pl_duration+' %:' + perc + ' width: '+ pwidth + ' of total: ' + _this.track_len);
823827 //var pwidth = Math.round( perc * _this.track_len - (_this.mv_seeker_width*perc) );
824828
825829 //add the buffer child indicator:
Index: branches/new-upload/phase3/js2/mwEmbed/skins/mvpcf/styles.css
@@ -197,11 +197,11 @@
198198 line-height: 32px;
199199 height: 29px;
200200 overflow: visible;
201 - font-size: 11px;
202 - width: 80px;
 201+ font-size: 10.4px;
 202+ width: 88px;
203203 float: right;
204204 display: inline;
205 - font-family:arial;
 205+ border:none;
206206 }
207207
208208 .videoPlayer .play_head{
Index: branches/new-upload/phase3/js2/mwEmbed/libEmbedVideo/mv_baseEmbed.js
@@ -439,7 +439,7 @@
440440 'time_display':{
441441 'w':80,
442442 'o':function(){
443 - return '<div id="mv_time_'+ctrlBuilder.id+'" class="time">'+ctrlBuilder.embedObj.getTimeReq()+'</div>'
 443+ return '<div id="mv_time_'+ctrlBuilder.id+'" class="ui-widget-content time">' + ctrlBuilder.embedObj.getTimeReq() + '</div>';
444444 }
445445 },
446446 'play_head':{

Status & tagging log