r51117 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51116‎ | r51117 | r51118 >
Date:14:02, 28 May 2009
Author:werdna
Status:deferred
Tags:
Comment:
Fix Special:NewMessages, transition to different storage type was confusing the system.
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/LqtNewMessages.php (modified) (history)
  • /trunk/extensions/LiquidThreads/pages/SpecialNewMessages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/LqtNewMessages.php
@@ -77,9 +77,14 @@
7878
7979 static function newUserMessages( $user ) {
8080 global $wgDBprefix;
 81+
 82+ $talkPage = new Article( $user->getUserPage()->getTalkPage() );
8183 return Threads::where( array( 'ums_read_timestamp is null',
82 - Threads::articleClause( new Article( $user->getUserPage() ) ) ),
83 - array(), array(), "left outer join {$wgDBprefix}user_message_state on ums_user is null or (ums_user = {$user->getID()} and ums_thread = thread.thread_id)" );
 84+ Threads::articleClause( $talkPage ) ),
 85+ array(), array(),
 86+ "left outer join {$wgDBprefix}user_message_state on " .
 87+ "ums_user is null or ".
 88+ "(ums_user = {$user->getID()} and ums_thread = thread.thread_id)" );
8489 }
8590
8691 static function watchedThreadsForUser( $user ) {
Index: trunk/extensions/LiquidThreads/pages/SpecialNewMessages.php
@@ -26,9 +26,12 @@
2727 $this->request = $wgRequest;
2828
2929 $this->setHeaders();
 30+
 31+ $article = new Article( $this->getTitle() );
 32+ $title = $this->getTitle();
3033
31 - $view = new NewUserMessagesView( $this->output, new Article( $this->getTitle() ),
32 - $this->getTitle(), $this->user, $this->request );
 34+ $view = new NewUserMessagesView( $this->output, $article,
 35+ $title, $this->user, $this->request );
3336
3437 $view->showOnce(); // handles POST etc.
3538

Status & tagging log