r51081 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r51080‎ | r51081 | r51082 >
Date:18:23, 27 May 2009
Author:tparscal
Status:resolved (Comments)
Tags:
Comment:
Corrected the padding of the siteNotice box.
Modified paths:
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
——@@ -281,7 +281,7 @@
282282 #siteNotice {
283283 text-align: center;
284284 font-size: 95%;
285 - padding: 0 .9em;
 285+ padding-top: 0.9em;
286286 }
287287 #siteNotice p {
288288 margin: 0;

Follow-up revisions

RevisionCommit summaryAuthorDate
r52299* bug 19219: fix style regression caused by mistaken cleanup in r51081brion01:18, 23 June 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   01:16, 23 June 2009

This causes a style regression reported in bug 19219; change appears to have been made due to mistaken impression of what the code did?

Explanation: "padding: 0 .9em" sets the top/bottom padding to 0 and the left/right padding to 0.9em.

"padding-top: 0.9em" sets the top padding to 0.9em and leaves the top/left/right padding unset -- totally different.

I'm changing it to "padding: 0 0.9em" to make it clearer that it's not a mistake for "0.9".

Status & tagging log