r51076 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51075‎ | r51076 | r51077 >
Date:16:17, 27 May 2009
Author:werdna
Status:deferred
Tags:
Comment:
(bug 18950) Clicking link for an invalid thread gives fatal errors instead of graceful failure.
Modified paths:
  • /trunk/extensions/LiquidThreads/Lqt.i18n.php (modified) (history)
  • /trunk/extensions/LiquidThreads/pages/ThreadPermalinkView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/pages/ThreadPermalinkView.php
@@ -13,7 +13,10 @@
1414 if ($this->thread) {
1515 $article_t = $this->thread->article()->getTitle();
1616 $talk_t = $this->thread->article()->getTitle();
 17+ } else {
 18+ return true;
1719 }
 20+
1821 efInsertIntoAssoc( 'article', array(
1922 'text' => wfMsg( $article_t->getNamespaceKey() ),
2023 'href' => $article_t->getFullURL(),
@@ -64,6 +67,7 @@
6568
6669 function showMissingThreadPage() {
6770 wfLoadExtensionMessages( 'LiquidThreads' );
 71+ $this->output->setPageTitle( wfMsg( 'lqt_nosuchthread_title' ) );
6872 $this->output->addHTML( wfMsg( 'lqt_nosuchthread' ) );
6973 }
7074
Index: trunk/extensions/LiquidThreads/Lqt.i18n.php
@@ -70,7 +70,8 @@
7171 'lqt_summary_label' => 'This thread has been summarized as follows:',
7272 'lqt_summary_subtitle' => 'the summary of $1.',
7373 'lqt_nosuchrevision' => 'There is no such revision of this thread.',
74 - 'lqt_nosuchthread' => 'There is no such thread.',
 74+ 'lqt_nosuchthread' => 'The thread you specified does not exist.',
 75+ 'lqt_nosuchthread_title' => 'No such thread',
7576 'lqt_threadrequired' => 'You must specify a thread in the URL.',
7677 'lqt_move_movingthread' => 'Moving $1.
7778 This thread is part of $2.',

Status & tagging log