r51043 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51042‎ | r51043 | r51044 >
Date:04:59, 27 May 2009
Author:yaron
Status:deferred
Tags:
Comment:
Fixed major bug in which textareas weren't getting displayed in IE
Modified paths:
  • /trunk/extensions/ReplaceText/SpecialReplaceText.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ReplaceText/SpecialReplaceText.php
@@ -224,13 +224,14 @@
225225 $wgOut->addHTML( '<table><tr><td style="vertical-align: top;">' );
226226 $wgOut->addWikiMsg( 'replacetext_originaltext' );
227227 $wgOut->addHTML( '</td><td>' );
228 - $wgOut->addHTML( Xml::textarea( 'target', $this->target, 50, 2 ) );
229 - $wgOut->addHTML( Xml::closeElement( 'textarea' ) );
 228+ // 'width: auto' style is needed to override MediaWiki's
 229+ // normal 'width: 100%', which causes the textarea to get
 230+ // zero width in IE
 231+ $wgOut->addHTML( Xml::textarea( 'target', $this->target, 50, 2, array( 'style' => 'width: auto;' ) ) );
230232 $wgOut->addHTML( '</td></tr><tr><td style="vertical-align: top;">' );
231233 $wgOut->addWikiMsg( 'replacetext_replacementtext' );
232234 $wgOut->addHTML( '</td><td>' );
233 - $wgOut->addHTML( Xml::textarea( 'replacement', $this->replacement, 50, 2 ) );
234 - $wgOut->addHTML( Xml::closeElement( 'textarea' ) );
 235+ $wgOut->addHTML( Xml::textarea( 'replacement', $this->replacement, 50, 2, array( 'style' => 'width: auto;' ) ) );
235236 $wgOut->addHTML( '</td></tr></table>' );
236237
237238 $search_label = wfMsg('powersearch-ns');

Status & tagging log