r51025 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r51024‎ | r51025 | r51026 >
Date:15:20, 26 May 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Fix for r50955, don't use the skin of the target user when linking to them.
Modified paths:
  • /trunk/phase3/includes/Credits.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Credits.php
@@ -162,13 +162,13 @@
163163 * @return String: html
164164 */
165165 protected static function link( User $user ) {
166 - global $wgHiddenPrefs;
 166+ global $wgUser, $wgHiddenPrefs;
167167 if( !in_array( 'realname', $wgHiddenPrefs ) )
168168 $real = $user->getRealName();
169169 else
170170 $real = false;
171171
172 - $skin = $user->getSkin();
 172+ $skin = $wgUser->getSkin();
173173 $page = $user->getUserPage();
174174
175175 return $skin->link( $page, htmlspecialchars( $real ? $real : $user->getName() ) );
@@ -203,4 +203,4 @@
204204 $skin = $wgUser->getSkin();
205205 return $skin->link( $article->getTitle(), wfMsgHtml( 'others' ), array(), array( 'action' => 'credits' ), array( 'known' ) );
206206 }
207 -}
\ No newline at end of file
 207+}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50955Update per r50782:...robin12:09, 24 May 2009

Status & tagging log