r50995 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50994‎ | r50995 | r50996 >
Date:00:07, 26 May 2009
Author:aaron
Status:ok
Tags:
Comment:
Removed error suppression
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/RatingHistory_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/RatingHistory_body.php
@@ -160,11 +160,11 @@
161161 Xml::closeElement( 'div' ) . "\n";
162162 }
163163 break;
164 - default:
 164+ default: // use html table
165165 if( $exists ) {
166 - $fp = @fopen( $filePath, 'r' );
 166+ $fp = fopen( $filePath, 'r' );
167167 $table = fread( $fp, filesize($filePath) );
168 - @fclose( $fp );
 168+ fclose( $fp );
169169 $html .= '<h2>' . wfMsgHtml("readerfeedback-$tag") . '</h2>' . $table . "\n";
170170 } else if( $table = $this->makeHTMLTable( $tag, $filePath ) ) {
171171 $html .= '<h2>' . wfMsgHtml("readerfeedback-$tag") . '</h2>' . $table . "\n";
@@ -237,9 +237,9 @@
238238 $chart .= "</table>\n";
239239 $chart .= Xml::closeElement( 'div' );
240240 // Write to file for cache
241 - $fp = @fopen( $filePath, 'w' );
242 - @fwrite( $fp, $chart );
243 - @fclose( $fp );
 241+ $fp = fopen( $filePath, 'w' );
 242+ fwrite( $fp, $chart );
 243+ fclose( $fp );
244244 return $chart;
245245 }
246246

Status & tagging log