r50978 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50977‎ | r50978 | r50979 >
Date:14:02, 25 May 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
urlencode not needed anymore
Modified paths:
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -241,8 +241,8 @@
242242 * @return string
243243 */
244244 protected function makeMetadataTable( $metadata ) {
245 - $r = "<div class=\"mw-imagepage-section-metadata\">\n";
246 - $r .= wfMsg( 'metadata-help' );
 245+ $r = "<div class=\"mw-imagepage-section-metadata\">";
 246+ $r .= wfMsgNoTrans( 'metadata-help' );
247247 $r .= "<table id=\"mw_metadata\" class=\"mw_metadata\">\n";
248248 foreach ( $metadata as $type => $stuff ) {
249249 foreach ( $stuff as $v ) {
@@ -474,7 +474,7 @@
475475 $uploadTitle = SpecialPage::getTitleFor( 'Upload' );
476476 $nofile = wfMsgHtml(
477477 'filepage-nofile-link',
478 - $uploadTitle->getFullUrl( array( 'wpDestFile' => urlencode( $this->img->getName() ) ) )
 478+ $uploadTitle->getFullUrl( array( 'wpDestFile' => $this->img->getName() ) )
479479 );
480480 }
481481 else
@@ -518,7 +518,7 @@
519519 $this->loadFile();
520520 $uploadTitle = SpecialPage::getTitleFor( 'Upload' );
521521 return $uploadTitle->getFullUrl( array(
522 - 'wpDestFile' => urlencode( $this->img->getName() ),
 522+ 'wpDestFile' => $this->img->getName(),
523523 'wpForReUpload' => 1
524524 ) );
525525 }

Status & tagging log