r50951 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50950‎ | r50951 | r50952 >
Date:08:59, 24 May 2009
Author:siebrand
Status:ok
Tags:
Comment:
Remove deprecated userCanCreate(), userCanEdit(), userCanMove(). Methods were deprecated in r19193 (2007-01-13) and are no longer used in current trunk or extensions.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/FakeTitle.php (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1464,33 +1464,6 @@
14651465 }
14661466
14671467 /**
1468 - * Can $wgUser edit this page?
1469 - * @return \type{\bool} TRUE or FALSE
1470 - * @deprecated use userCan('edit')
1471 - */
1472 - public function userCanEdit( $doExpensiveQueries = true ) {
1473 - return $this->userCan( 'edit', $doExpensiveQueries );
1474 - }
1475 -
1476 - /**
1477 - * Can $wgUser create this page?
1478 - * @return \type{\bool} TRUE or FALSE
1479 - * @deprecated use userCan('create')
1480 - */
1481 - public function userCanCreate( $doExpensiveQueries = true ) {
1482 - return $this->userCan( 'create', $doExpensiveQueries );
1483 - }
1484 -
1485 - /**
1486 - * Can $wgUser move this page?
1487 - * @return \type{\bool} TRUE or FALSE
1488 - * @deprecated use userCan('move')
1489 - */
1490 - public function userCanMove( $doExpensiveQueries = true ) {
1491 - return $this->userCan( 'move', $doExpensiveQueries );
1492 - }
1493 -
1494 - /**
14951468 * Would anybody with sufficient privileges be able to move this page?
14961469 * Some pages just aren't movable.
14971470 *
Index: trunk/phase3/includes/FakeTitle.php
@@ -38,9 +38,6 @@
3939 function isProtected( $action = '' ) { $this->error(); }
4040 function userIsWatching() { $this->error(); }
4141 function userCan( $action, $doExpensiveQueries = true ) { $this->error(); }
42 - function userCanCreate() { $this->error(); }
43 - function userCanEdit( $doExpensiveQueries = true ) { $this->error(); }
44 - function userCanMove() { $this->error(); }
4542 function isMovable() { $this->error(); }
4643 function userCanRead() { $this->error(); }
4744 function isTalkPage() { $this->error(); }
Index: trunk/phase3/RELEASE-NOTES
@@ -147,10 +147,13 @@
148148 * (bug 18522) Wrap MediaWiki:Protect-cascadeon in a div for identification
149149 * (bug 18438) Tweak HTML for preview bar for consistency and accessibility
150150 * (bug 18432) Updated documentation for dumpBackup.php
151 -* Fix array logic in Sanitizer::removeHTMLtags so that it doesn't strip good tags
152 - that were redundantly defined.
 151+* Fix array logic in Sanitizer::removeHTMLtags so that it doesn't strip good
 152+ tags that were redundantly defined.
153153 * (bug 14118) SpecialPage::getTitleFor does not return a localised name
154 -* (bug 18698) Renaming non entry point maintenance scripts from .inc.php to .inc
 154+* (bug 18698) Renaming non entry point maintenance scripts from .inc.php to
 155+ .inc
 156+* Deprecated methods userCanCreate(), userCanEdit() and userCanMove() have been
 157+ removed
155158
156159 == API changes in 1.16 ==
157160

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r19193* fix last commit so quickUserCan() actually skips the cascading query...brion03:22, 13 January 2007

Status & tagging log