r50948 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r50947‎ | r50948 | r50949 >
Date:08:33, 24 May 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Proper casing for getDBkey()
Modified paths:
  • /trunk/extensions/AbuseFilter/AbuseFilter.class.php (modified) (history)
  • /trunk/extensions/AbuseFilter/SpecialAbuseLog.php (modified) (history)
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewTestBatch.php (modified) (history)
  • /trunk/extensions/CheckUser/CheckUser_body.php (modified) (history)
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)
  • /trunk/extensions/DPLforum/DPLforum_body.php (modified) (history)
  • /trunk/extensions/Drafts/Drafts.classes.php (modified) (history)
  • /trunk/extensions/DynamicPageList/DynamicPageList2.php (modified) (history)
  • /trunk/extensions/EmergencyDeSysop/EmergencyDeSysop.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Overlay.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_SequencePlayer.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_Title.php (modified) (history)
  • /trunk/extensions/MetavidWiki/maintenance/maintenance_util.inc.php (modified) (history)
  • /trunk/extensions/OpenSearchXml/ApiOpenSearchXml.php (modified) (history)
  • /trunk/extensions/Oversight/HideRevision_body.php (modified) (history)
  • /trunk/extensions/PlayerStatsGrabber/PlayerStatsGrabber_body.php (modified) (history)
  • /trunk/extensions/Renameuser/SpecialRenameuser_body.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QueryProcessor.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_PropertyPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/export/SMW_Exporter.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_RAPStore2.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2_Queries.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/Export/SMW_SpecialOWLExport.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserStats/UserStatsClass.php (modified) (history)
  • /trunk/extensions/Translate/SpecialMagic.php (modified) (history)
  • /trunk/extensions/Translate/SpecialTranslations.php (modified) (history)
  • /trunk/extensions/Translate/tag/PageTranslationHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PlayerStatsGrabber/PlayerStatsGrabber_body.php
——@@ -78,7 +78,7 @@
7979 // print "EMBED C: $embed_code \n";
8080 // $q = 'action='.$this->action;
8181 # if ( "no" == $redirect ) { $q .= "&redirect=no"; }
82 - // $action = $wgScript.'?title='.$wgTitle->getDBKey() . '/Thanks';
 82+ // $action = $wgScript.'?title='.$wgTitle->getDBkey() . '/Thanks';
8383 $action = $wgTitle->getLocalURL( 'action=submit' );
8484 $jsUserHash = sha1( $wgUser->getName() . $wgProxyKey );
8585 $enUserHash = Xml::encodeJsVar( $jsUserHash );
Index: trunk/extensions/SemanticMediaWiki/specials/Export/SMW_SpecialOWLExport.php
——@@ -262,7 +262,7 @@
263263 $title = Title::newFromText($page);
264264 if (NULL === $title) continue; //invalid title name given
265265 $st = new SMWSmallTitle();
266 - $st->dbkey = $title->getDBKey();
 266+ $st->dbkey = $title->getDBkey();
267267 $st->namespace = $title->getNamespace();
268268 $cur_queue[] = $st;
269269 }
——@@ -343,7 +343,7 @@
344344 if ( ($title === NULL) || !smwfIsSemanticsProcessed($title->getNamespace()) ) continue;
345345 if ( !OWLExport::fitsNsRestriction($ns_restriction, $title->getNamespace()) ) continue;
346346 $st = new SMWSmallTitle();
347 - $st->dbkey = $title->getDBKey();
 347+ $st->dbkey = $title->getDBkey();
348348 $st->namespace = $title->getNamespace();
349349 $cur_queue = array($st);
350350 $a_count++; //DEBUG
——@@ -677,7 +677,7 @@
678678 $inSubs = smwfGetStore()->getPropertySubjects( $inRel, $value );
679679 foreach($inSubs as $inSub) {
680680 $stb = new SMWSmallTitle();
681 - $stb->dbkey = $inSub->getDBKey();
 681+ $stb->dbkey = $inSub->getDBkey();
682682 $stb->namespace = $inSub->getNamespace();
683683 if (!array_key_exists($stb->getHash(), $this->element_done)) {
684684 $semdata = smwfGetStore()->getSemanticData($inSub, array('__spu', '__typ', '__imp'));
——@@ -694,7 +694,7 @@
695695 $pinst = SMWPropertyValue::makeProperty('_INST');
696696 foreach($instances as $instance) {
697697 $stb = new SMWSmallTitle();
698 - $stb->dbkey = $instance->getDBKey();
 698+ $stb->dbkey = $instance->getDBkey();
699699 $stb->namespace = $instance->getNamespace();
700700 if (!array_key_exists($stb->getHash(), $this->element_done)) {
701701 $semdata = smwfGetStore()->getSemanticData($instance, array('__spu', '__typ', '__imp'));
——@@ -715,7 +715,7 @@
716716 while ($resarray !== false) {
717717 $instance = end($resarray)->getNextObject();
718718 $stb = new SMWSmallTitle();
719 - $stb->dbkey = $instance->getDBKey();
 719+ $stb->dbkey = $instance->getDBkey();
720720 $stb->namespace = $instance->getNamespace();
721721 if (!array_key_exists($stb->getHash(), $this->element_done)) {
722722 $semdata = smwfGetStore()->getSemanticData($instance, array('__spu', '__typ', '__imp'));
——@@ -795,7 +795,7 @@
796796 if ($title instanceof SMWWikiPageValue) {
797797 $spt = new SMWSmallTitle();
798798 $title = $title->getTitle();
799 - $spt->dbkey = $title->getDBKey();
 799+ $spt->dbkey = $title->getDBkey();
800800 $spt->namespace = $title->getNamespace();
801801 $spt->modifier = $element->getModifier();
802802 if ( !array_key_exists($spt->getHash(), $this->element_done) ) {
Index: trunk/extensions/SemanticMediaWiki/includes/export/SMW_Exporter.php
——@@ -200,7 +200,7 @@
201201 if ($dv->getNamespace() == SMW_NS_PROPERTY) {
202202 $namespace = '&property;';
203203 $namespaceid = 'property';
204 - $localname = SMWExporter::encodeURI(rawurlencode($dv->getTitle()->getDBKey()));
 204+ $localname = SMWExporter::encodeURI(rawurlencode($dv->getTitle()->getDBkey()));
205205 if (in_array($localname[0], array('-','0','1','2','3','4','5','6','7','8','9'))) {
206206 $namespace = '&wiki;';
207207 $namespaceid = 'wiki';
Index: trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_PropertyPage.php
——@@ -25,7 +25,7 @@
2626 protected function initParameters() {
2727 global $smwgContLang, $smwgPropertyPagingLimit;
2828 $this->limit = $smwgPropertyPagingLimit;
29 - $this->mProperty = SMWPropertyValue::makeProperty($this->mTitle->getDBKey());
 29+ $this->mProperty = SMWPropertyValue::makeProperty($this->mTitle->getDBkey());
3030 return true;
3131 }
3232
Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2_Queries.php
——@@ -78,8 +78,8 @@
7979 */
8080 public function refreshConceptCache($concept) {
8181 global $smwgQMaxLimit, $smwgQConceptFeatures, $wgDBtype;
82 - $cid = $this->m_store->getSMWPageID($concept->getDBKey(), SMW_NS_CONCEPT, '');
83 - $cid_c = $this->m_store->getSMWPageID($concept->getDBKey(), SMW_NS_CONCEPT, '', false);
 82+ $cid = $this->m_store->getSMWPageID($concept->getDBkey(), SMW_NS_CONCEPT, '');
 83+ $cid_c = $this->m_store->getSMWPageID($concept->getDBkey(), SMW_NS_CONCEPT, '', false);
8484 if ($cid != $cid_c) {
8585 $this->m_errors[] = "Skipping redirect concept.";
8686 return $this->m_errors;
——@@ -135,7 +135,7 @@
136136 * @param $concept Title
137137 */
138138 public function deleteConceptCache($concept) {
139 - $cid = $this->m_store->getSMWPageID($concept->getDBKey(), SMW_NS_CONCEPT, '', false);
 139+ $cid = $this->m_store->getSMWPageID($concept->getDBkey(), SMW_NS_CONCEPT, '', false);
140140 $this->m_dbs->delete('smw_conccache', array('o_id' => $cid), 'SMW::refreshConceptCache');
141141 $this->m_dbs->update('smw_conc2', array('cache_date' => NULL, 'cache_count' => NULL), array('s_id' => $cid), 'SMW::refreshConceptCache');
142142 }
——@@ -403,7 +403,7 @@
404404 }
405405 }
406406 } elseif ($description instanceof SMWConceptDescription) { // fetch concept definition and insert it here
407 - $cid = $this->m_store->getSMWPageID($description->getConcept()->getDBKey(), SMW_NS_CONCEPT, '');
 407+ $cid = $this->m_store->getSMWPageID($description->getConcept()->getDBkey(), SMW_NS_CONCEPT, '');
408408 $row = $this->m_dbs->selectRow('smw_conc2',
409409 array('concept_txt','concept_features','concept_size','concept_depth','cache_date'),
410410 array('s_id'=>$cid), 'SMWSQLStore2Queries::compileQueries');
Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_RAPStore2.php
——@@ -160,13 +160,13 @@
161161 $this->removeSubjectFromRAP($rdfmodel, $rapsubold);
162162
163163 $newpage = SMWDataValueFactory::newTypeIDValue('_wpg');
164 - $newpage->setValues($newtitle->getDBKey(), $newtitle->getNamespace(), $pageid);
 164+ $newpage->setValues($newtitle->getDBkey(), $newtitle->getNamespace(), $pageid);
165165 $semdata = $this->getSemanticData($newpage);
166166 $this->updateData($semdata,false);
167167
168168 // Save the old page
169169 $oldpage = SMWDataValueFactory::newTypeIDValue('_wpg');
170 - $oldpage->setValues($oldtitle->getDBKey(), $oldtitle->getNamespace(), $redirid);
 170+ $oldpage->setValues($oldtitle->getDBkey(), $oldtitle->getNamespace(), $redirid);
171171 $semdata = $this->getSemanticData($oldpage);
172172 $this->updateData($semdata,false);
173173
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QueryProcessor.php
——@@ -181,7 +181,7 @@
182182 }
183183 if ($title->getNamespace() == SMW_NS_PROPERTY) {
184184 $printmode = SMWPrintRequest::PRINT_PROP;
185 - $property = SMWPropertyValue::makeProperty($title->getDBKey());
 185+ $property = SMWPropertyValue::makeProperty($title->getDBkey());
186186 $data = $property;
187187 $label = $showmode?'':$property->getWikiValue(); // default
188188 } elseif ($title->getNamespace() == NS_CATEGORY) {
Index: trunk/extensions/SocialProfile/UserStats/UserStatsClass.php
——@@ -282,7 +282,7 @@
283283 $ctg = 'Opinions by User ' . ( $this->user_name );
284284 $parser = new Parser();
285285 $CtgTitle = Title::newFromText( $parser->transformMsg( trim( $ctg ), $wgOut->parserOptions() ) );
286 - $CtgTitle = $CtgTitle->getDBKey();
 286+ $CtgTitle = $CtgTitle->getDBkey();
287287 $dbw = wfGetDB( DB_MASTER );
288288 $sql = "UPDATE ".$wgDBprefix."user_stats SET stats_opinions_created=";
289289 $sql .= "(SELECT count(*) AS CreatedOpinions FROM {$dbw->tableName( 'page' )} INNER JOIN {$dbw->tableName( 'categorylinks' )} ON page_id = cl_from WHERE (cl_to) = " . $dbw->addQuotes($CtgTitle) . " ";
——@@ -301,7 +301,7 @@
302302 $dbw = wfGetDB( DB_MASTER );
303303 $ctg = 'Opinions by User ' . ( $this->user_name );
304304 $CtgTitle = Title::newFromText( $parser->transformMsg( trim( $ctg ), $wgOut->parserOptions() ) );
305 - $CtgTitle = $CtgTitle->getDBKey();
 305+ $CtgTitle = $CtgTitle->getDBkey();
306306 $sql = "UPDATE ".$wgDBprefix."user_stats SET stats_opinions_published = ";
307307 $sql .= "(SELECT count(*) AS PromotedOpinions FROM {$dbw->tableName( 'page' )} INNER JOIN {$dbw->tableName( 'categorylinks' )} ON page_id = cl_from INNER JOIN published_page ON page_id=published_page_id WHERE (cl_to) = " . $dbw->addQuotes($CtgTitle) . " AND published_type=1 " . " " . $timeSQL;
308308 $sql .= ")";
Index: trunk/extensions/MetavidWiki/maintenance/maintenance_util.inc.php
——@@ -103,7 +103,7 @@
104104 $wgTitle = Title::makeTitle( $ns, ucfirst( $wgTitle ) );
105105 }
106106
107 - if ( trim( $wgTitle->getDBKey() ) == '' ) {
 107+ if ( trim( $wgTitle->getDBkey() ) == '' ) {
108108 print "empty title (no insert /update) \n";
109109 return ;
110110 }
Index: trunk/extensions/MetavidWiki/includes/MV_Title.php
——@@ -36,11 +36,11 @@
3737 if ( is_string( $title ) ) {
3838 $title = parent::makeTitle( $ns, $title );
3939 }
40 - //print "RAN TITLE: ". $title->getDBKey();
 40+ //print "RAN TITLE: ". $title->getDBkey();
4141 $this->inheritTitle( $title ) ;
4242 // its just a plain string generate the parse info
43 - $this->wiki_title = $title->getDBKey();
44 - $this->parseTitle( $title->getDBKey() );
 43+ $this->wiki_title = $title->getDBkey();
 44+ $this->parseTitle( $title->getDBkey() );
4545 // print "mv_title stream name: " . $this->stream_name. "\n";
4646 }
4747 function inheritTitle( & $title ) {
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_Overlay.php
——@@ -617,7 +617,7 @@
618618 $o .= '<div id="mv_ext_cat_container_' . htmlspecialchars( $mvd_id ) . '"></div>';
619619 foreach ( $metaData['categories'] as $cat => $page ) {
620620 $catTitle = Title::newFromText( $cat, NS_CATEGORY );
621 - $o .= '<span id="ext_cat_' . htmlspecialchars( $i ) . '"><input value="' . $catTitle->getDBKey() . '" type="hidden" style="display:none;" name="ext_cat_' . $i . '" class="mv_ext_cat">' .
 621+ $o .= '<span id="ext_cat_' . htmlspecialchars( $i ) . '"><input value="' . $catTitle->getDBkey() . '" type="hidden" style="display:none;" name="ext_cat_' . $i . '" class="mv_ext_cat">' .
622622 $catTitle->getText() .
623623 '<a href="#" onclick="$j(\'#ext_cat_' . $i . '\').fadeOut(\'fast\').remove();return false;">
624624 <img border="0" src="' . $mvgScriptPath . '/skins/images/delete.png">
Index: trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_SequencePlayer.php
——@@ -31,7 +31,7 @@
3232 'src="' . $this->getExportUrl() . '"></playlist>';
3333 }
3434 function getExportUrl(){
35 - $exportTitle = Title::MakeTitle( NS_SPECIAL, 'MvExportSequence/' . $this->seqTitle->getDBKey() );
 35+ $exportTitle = Title::MakeTitle( NS_SPECIAL, 'MvExportSequence/' . $this->seqTitle->getDBkey() );
3636 $export_url = $exportTitle->getFullURL();
3737 if($this->oldid!=''){
3838 $ss = ( strpos( $export_url, '?' ) === false ) ? '?':'&';
Index: trunk/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php
——@@ -129,7 +129,7 @@
130130 if( $wgMiserMode ) {
131131 # Get a rough idea of size
132132 $count = $dbr->estimateRowCount( 'watchlist', '*',
133 - array( 'wl_namespace' => $title->getNamespace(), 'wl_title' => $title->getDBKey() ),
 133+ array( 'wl_namespace' => $title->getNamespace(), 'wl_title' => $title->getDBkey() ),
134134 __METHOD__ );
135135 }
136136 # If it is small, just COUNT() it, otherwise, stick with estimate...
——@@ -139,7 +139,7 @@
140140 $cutoff = $dbr->timestamp( wfTimestamp( TS_UNIX ) - 2*$wgCookieExpiration );
141141 $res = $dbr->select( array('watchlist','user'), '1',
142142 array( 'wl_namespace' => $title->getNamespace(),
143 - 'wl_title' => $title->getDBKey(),
 143+ 'wl_title' => $title->getDBkey(),
144144 'wl_user = user_id',
145145 // logged in or out
146146 'user_touched > '.$dbr->addQuotes( $cutoff ) ),
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
——@@ -333,7 +333,7 @@
334334 }
335335 # Check cache before doing another DB hit...
336336 $idP = FlaggedRevs::getTemplateIdFromCache( $parser->getRevisionId(),
337 - $title->getNamespace(), $title->getDBKey() );
 337+ $title->getNamespace(), $title->getDBkey() );
338338 # Use the process cache key if it's newer or we have none yet
339339 if( !is_null($idP) && (!$id || $idP > $id) ) {
340340 $id = $idP;
——@@ -381,7 +381,7 @@
382382 $isKnownLocal = $isLocalFile = false; // local file on this wiki?
383383 # Normalize NS_MEDIA to NS_FILE
384384 if( $nt->getNamespace() == NS_MEDIA ) {
385 - $title = Title::makeTitle( NS_FILE, $nt->getDBKey() );
 385+ $title = Title::makeTitle( NS_FILE, $nt->getDBkey() );
386386 $title->resetArticleId( $nt->getArticleId() ); // avoid extra queries
387387 } else {
388388 $title =& $nt;
——@@ -399,7 +399,7 @@
400400 }
401401 }
402402 # Check cache before doing another DB hit...
403 - $params = FlaggedRevs::getFileVersionFromCache( $parser->getRevisionId(), $title->getDBKey() );
 403+ $params = FlaggedRevs::getFileVersionFromCache( $parser->getRevisionId(), $title->getDBkey() );
404404 if( is_array($params) ) {
405405 list($timeP,$sha1P) = $params;
406406 // Take the newest one...
——@@ -485,7 +485,7 @@
486486 }
487487 }
488488 # Check cache before doing another DB hit...
489 - $params = FlaggedRevs::getFileVersionFromCache( $ig->mRevisionId, $nt->getDBKey() );
 489+ $params = FlaggedRevs::getFileVersionFromCache( $ig->mRevisionId, $nt->getDBkey() );
490490 if( is_array($params) ) {
491491 list($timeP,$sha1P) = $params;
492492 // Take the newest one...
——@@ -1055,7 +1055,7 @@
10561056 $dbr = wfGetDB( DB_SLAVE );
10571057 $blocked = $dbr->selectField( 'logging', '1',
10581058 array( 'log_namespace' => NS_USER,
1059 - 'log_title' => $user->getUserPage()->getDBKey(),
 1059+ 'log_title' => $user->getUserPage()->getDBkey(),
10601060 'log_type' => 'block',
10611061 'log_action' => 'block' ),
10621062 __METHOD__,
——@@ -1074,7 +1074,7 @@
10751075 $dbr = isset($dbr) ? $dbr : wfGetDB( DB_SLAVE );
10761076 $size = $dbr->selectField( 'page', 'page_len',
10771077 array( 'page_namespace' => $user->getUserPage()->getNamespace(),
1078 - 'page_title' => $user->getUserPage()->getDBKey() ),
 1078+ 'page_title' => $user->getUserPage()->getDBkey() ),
10791079 __METHOD__ );
10801080 if( $size < $wgFlaggedRevsAutopromote['userpageBytes'] ) {
10811081 return true;
Index: trunk/extensions/AbuseFilter/SpecialAbuseLog.php
——@@ -109,7 +109,7 @@
110110 $searchTitle = Title::newFromText( $this->mSearchTitle );
111111 if ( $this->mSearchTitle && $searchTitle ) {
112112 $conds['afl_namespace'] = $searchTitle->getNamespace();
113 - $conds['afl_title'] = $searchTitle->getDBKey();
 113+ $conds['afl_title'] = $searchTitle->getDBkey();
114114 }
115115
116116 $pager = new AbuseLogPager( $this, $conds );
Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewTestBatch.php
——@@ -96,7 +96,7 @@
9797 if ($this->mTestPage) {
9898 $title = Title::newFromText( $this->mTestPage );
9999 $conds['rc_namespace'] = $title->getNamespace();
100 - $conds['rc_title'] = $title->getDBKey();
 100+ $conds['rc_title'] = $title->getDBkey();
101101 }
102102
103103 // Get our ChangesList
Index: trunk/extensions/AbuseFilter/AbuseFilter.class.php
——@@ -695,7 +695,7 @@
696696 'afl_user_text' => $wgUser->getName(),
697697 'afl_timestamp' => $dbr->timestamp(wfTimestampNow()),
698698 'afl_namespace' => $title->getNamespace(),
699 - 'afl_title' => $title->getDBKey(),
 699+ 'afl_title' => $title->getDBkey(),
700700 'afl_ip' => wfGetIp() );
701701
702702 // Hack to avoid revealing IPs of people creating accounts
Index: trunk/extensions/Oversight/HideRevision_body.php
——@@ -604,7 +604,7 @@
605605 $this->mForm = $form;
606606 $this->mConds = $conds;
607607 $this->namespace = $title ? $title->getNamespace() : -1;
608 - $this->dbKey = $title ? $title->getDBKey() : null;
 608+ $this->dbKey = $title ? $title->getDBkey() : null;
609609 $this->uid = $user ? $user->getId() : null;
610610 if( strlen($offender) ) {
611611 $offender = User::newFromName( $offender, false );
Index: trunk/extensions/Collection/Collection.body.php
——@@ -375,7 +375,7 @@
376376 );
377377 $where = array(
378378 'cl_from=page_id',
379 - 'cl_to' => $title->getDBKey(),
 379+ 'cl_to' => $title->getDBkey(),
380380 );
381381 $res = $db->select( $tables, $fields, $where, __METHOD__, $options );
382382 $members = array();
Index: trunk/extensions/Renameuser/SpecialRenameuser_body.php
——@@ -440,10 +440,10 @@
441441 $oldTitle = Title::makeTitle( NS_USER, $this->old );
442442 $newTitle = Title::makeTitle( NS_USER, $this->new );
443443 $dbw->update( 'logging',
444 - array( 'log_title' => $newTitle->getDBKey() ),
 444+ array( 'log_title' => $newTitle->getDBkey() ),
445445 array( 'log_type' => array( 'block', 'rights' ),
446446 'log_namespace' => NS_USER,
447 - 'log_title' => $oldTitle->getDBKey() ),
 447+ 'log_title' => $oldTitle->getDBkey() ),
448448 __METHOD__ );
449449 // Do immediate updates!
450450 foreach( $this->tables as $table => $fieldSet ) {
Index: trunk/extensions/Drafts/Drafts.classes.php
——@@ -46,7 +46,7 @@
4747 // Adds new page information to conditions
4848 $where['draft_page'] = 0; // page not created yet
4949 $where['draft_namespace'] = $title->getNamespace();
50 - $where['draft_title'] = $title->getDBKey();
 50+ $where['draft_title'] = $title->getDBkey();
5151 }
5252 }
5353 // Checks if specific user was given
——@@ -99,7 +99,7 @@
100100 $dbw->update( 'drafts',
101101 array(
102102 'draft_namespace' => $newTitle->getNamespace(),
103 - 'draft_title' => $newTitle->getDBKey()
 103+ 'draft_title' => $newTitle->getDBkey()
104104 ),
105105 array(
106106 'draft_page' => $newTitle->getArticleId()
——@@ -140,7 +140,7 @@
141141 } else {
142142 // Adds new page information to conditions
143143 $where['draft_namespace'] = $title->getNamespace();
144 - $where['draft_title'] = $title->getDBKey();
 144+ $where['draft_title'] = $title->getDBkey();
145145 }
146146 }
147147 // Checks if a specific user was given
——@@ -654,7 +654,7 @@
655655 'draft_token' => (int) $this->getToken(),
656656 'draft_user' => (int) $wgUser->getID(),
657657 'draft_namespace' => (int) $this->title->getNamespace(),
658 - 'draft_title' => (string) $this->title->getDBKey(),
 658+ 'draft_title' => (string) $this->title->getDBkey(),
659659 'draft_page' => (int) $this->title->getArticleId(),
660660 'draft_section' =>
661661 $this->section == '' ? null : (int) $this->section,
Index: trunk/extensions/DynamicPageList/DynamicPageList2.php
——@@ -1453,12 +1453,12 @@
14541454 $sParamList = explode('|',self::getSubcategories(substr($sParam,1),$sPageTable));
14551455 foreach ($sParamList as $sPar) {
14561456 $title = Title::newFromText($localParser->transformMsg($sPar, $pOptions));
1457 - if( !is_null($title) ) $aCategories[] = $title->getDBKey();
 1457+ if( !is_null($title) ) $aCategories[] = $title->getDBkey();
14581458 }
14591459 }
14601460 else {
14611461 $title = Title::newFromText($localParser->transformMsg($sParam, $pOptions));
1462 - if( !is_null($title) ) $aCategories[] = $title->getDBKey();
 1462+ if( !is_null($title) ) $aCategories[] = $title->getDBkey();
14631463 }
14641464 }
14651465 }
——@@ -1491,7 +1491,7 @@
14921492 case 'notcategory':
14931493 $title = Title::newFromText($localParser->transformMsg($sArg, $pOptions));
14941494 if( !is_null($title) ) {
1495 - $aExcludeCategories[] = $title->getDBKey();
 1495+ $aExcludeCategories[] = $title->getDBkey();
14961496 $bConflictsWithOpenReferences=true;
14971497 }
14981498 break;
——@@ -2591,8 +2591,8 @@
25922592 foreach ($aLinksTo as $link) {
25932593 if ($n>0) $sSqlCond_page_pl .= ' OR ';
25942594 $sSqlCond_page_pl .= '(pl.pl_namespace=' . intval( $link->getNamespace() );
2595 - if ($bIgnoreCase) $sSqlCond_page_pl .= " AND LOWER(pl.pl_title)=LOWER(" . $dbr->addQuotes( $link->getDBKey() ).'))';
2596 - else $sSqlCond_page_pl .= " AND pl.pl_title=" . $dbr->addQuotes( $link->getDBKey() ).')';
 2595+ if ($bIgnoreCase) $sSqlCond_page_pl .= " AND LOWER(pl.pl_title)=LOWER(" . $dbr->addQuotes( $link->getDBkey() ).'))';
 2596+ else $sSqlCond_page_pl .= " AND pl.pl_title=" . $dbr->addQuotes( $link->getDBkey() ).')';
25972597 $n++;
25982598 }
25992599 $sSqlCond_page_pl .= ')';
——@@ -2605,8 +2605,8 @@
26062606 foreach ($aNotLinksTo as $link) {
26072607 if ($n>0) $sSqlCond_page_pl .= ' OR ';
26082608 $sSqlCond_page_pl .= '('.$sPageLinksTable.'.pl_namespace=' . intval($link->getNamespace());
2609 - if ($bIgnoreCase) $sSqlCond_page_pl .= ' AND LOWER('.$sPageLinksTable.'.pl_title)=LOWER(' . $dbr->addQuotes( $link->getDBKey() ).'))';
2610 - else $sSqlCond_page_pl .= ' AND '.$sPageLinksTable.'.pl_title=' . $dbr->addQuotes( $link->getDBKey() ).')';
 2609+ if ($bIgnoreCase) $sSqlCond_page_pl .= ' AND LOWER('.$sPageLinksTable.'.pl_title)=LOWER(' . $dbr->addQuotes( $link->getDBkey() ).'))';
 2610+ else $sSqlCond_page_pl .= ' AND '.$sPageLinksTable.'.pl_title=' . $dbr->addQuotes( $link->getDBkey() ).')';
26112611 $n++;
26122612 }
26132613 $sSqlCond_page_pl .= ') )';
——@@ -2671,8 +2671,8 @@
26722672 $n=0;
26732673 foreach ($aImageUsed as $link) {
26742674 if ($n>0) $sSqlCond_page_pl .= ' OR ';
2675 - if ($bIgnoreCase) $sSqlCond_page_pl .= "LOWER(il.il_to)=LOWER(" . $dbr->addQuotes( $link->getDBKey() ).')';
2676 - else $sSqlCond_page_pl .= "il.il_to=" . $dbr->addQuotes( $link->getDBKey() );
 2675+ if ($bIgnoreCase) $sSqlCond_page_pl .= "LOWER(il.il_to)=LOWER(" . $dbr->addQuotes( $link->getDBkey() ).')';
 2676+ else $sSqlCond_page_pl .= "il.il_to=" . $dbr->addQuotes( $link->getDBkey() );
26772677 $n++;
26782678 }
26792679 $sSqlCond_page_pl .= ')';
——@@ -2705,8 +2705,8 @@
27062706 foreach ($aUses as $link) {
27072707 if ($n>0) $sSqlCond_page_pl .= ' OR ';
27082708 $sSqlCond_page_pl .= '(tl.tl_namespace=' . intval( $link->getNamespace() );
2709 - if ($bIgnoreCase) $sSqlCond_page_pl .= " AND LOWER(tl.tl_title)=LOWER(" . $dbr->addQuotes( $link->getDBKey() ).'))';
2710 - else $sSqlCond_page_pl .= " AND tl.tl_title=" . $dbr->addQuotes( $link->getDBKey() ).')';
 2709+ if ($bIgnoreCase) $sSqlCond_page_pl .= " AND LOWER(tl.tl_title)=LOWER(" . $dbr->addQuotes( $link->getDBkey() ).'))';
 2710+ else $sSqlCond_page_pl .= " AND tl.tl_title=" . $dbr->addQuotes( $link->getDBkey() ).')';
27112711 $n++;
27122712 }
27132713 $sSqlCond_page_pl .= ')';
——@@ -2719,8 +2719,8 @@
27202720 foreach ($aNotUses as $link) {
27212721 if ($n>0) $sSqlCond_page_pl .= ' OR ';
27222722 $sSqlCond_page_pl .= '('.$sTemplateLinksTable.'.tl_namespace=' . intval($link->getNamespace());
2723 - if ($bIgnoreCase) $sSqlCond_page_pl .= ' AND LOWER('.$sTemplateLinksTable.'.tl_title)=LOWER(' . $dbr->addQuotes( $link->getDBKey() ).'))';
2724 - else $sSqlCond_page_pl .= ' AND '.$sTemplateLinksTable.'.tl_title=' . $dbr->addQuotes( $link->getDBKey() ).')';
 2723+ if ($bIgnoreCase) $sSqlCond_page_pl .= ' AND LOWER('.$sTemplateLinksTable.'.tl_title)=LOWER(' . $dbr->addQuotes( $link->getDBkey() ).'))';
 2724+ else $sSqlCond_page_pl .= ' AND '.$sTemplateLinksTable.'.tl_title=' . $dbr->addQuotes( $link->getDBkey() ).')';
27252725 $n++;
27262726 }
27272727 $sSqlCond_page_pl .= ') )';
Index: trunk/extensions/OpenSearchXml/ApiOpenSearchXml.php
——@@ -243,7 +243,7 @@
244244 // Others will take Image:Foo.jpg or Foo.jpg
245245 $title = Title::newFromText( $arg, NS_IMAGE );
246246 if( $title && $title->getNamespace() == NS_IMAGE ) {
247 - return $title->getDBKey();
 247+ return $title->getDBkey();
248248 }
249249 return false;
250250 }
Index: trunk/extensions/EmergencyDeSysop/EmergencyDeSysop.php
——@@ -39,7 +39,7 @@
4040 $text = wfMsg('emergencydesysop');
4141
4242 $title = Title::newFromText($text);
43 - $specialPageArray['emergencydesysop']['emergencydesysop'] = $title->getDBKey();
 43+ $specialPageArray['emergencydesysop']['emergencydesysop'] = $title->getDBkey();
4444 return true;
4545 }
4646
Index: trunk/extensions/DPLforum/DPLforum_body.php
——@@ -281,13 +281,13 @@
282282 for ( $i = 0; $i < $cats; $i++ ) {
283283 $sSqlSelectFrom .= " INNER JOIN $categorylinks AS" .
284284 " c{$n} ON page_id = c{$n}.cl_from AND c{$n}.cl_to=" .
285 - $dbr->addQuotes( $aCategories[$i]->getDBKey() );
 285+ $dbr->addQuotes( $aCategories[$i]->getDBkey() );
286286 $n++;
287287 }
288288 for ( $i = 0; $i < $nocats; $i++ ) {
289289 $sSqlSelectFrom .= " LEFT OUTER JOIN $categorylinks AS" .
290290 " c{$n} ON page_id = c{$n}.cl_from AND c{$n}.cl_to=" .
291 - $dbr->addQuotes( $aExcludeCategories[$i]->getDBKey() );
 291+ $dbr->addQuotes( $aExcludeCategories[$i]->getDBkey() );
292292 $sSqlWhere .= " AND c{$n}.cl_to IS NULL";
293293 $n++;
294294 }
Index: trunk/extensions/Translate/tag/PageTranslationHooks.php
——@@ -173,7 +173,7 @@
174174
175175 // Add links to other languages
176176 $suffix = ( $code === 'en' ) ? '' : "/$code";
177 - $_title = Title::makeTitle( $title->getNamespace(), $title->getDBKey() . $suffix );
 177+ $_title = Title::makeTitle( $title->getNamespace(), $title->getDBkey() . $suffix );
178178
179179 // For some reason self-links are not done automatically
180180 if ( $parser->getTitle()->getText() === $_title->getText() ) {
Index: trunk/extensions/Translate/SpecialTranslations.php
——@@ -109,7 +109,7 @@
110110 $sk = $wgUser->getSkin();
111111
112112 $namespace = $title->getNamespace();
113 - $message = $title->getDBKey();
 113+ $message = $title->getDBkey();
114114
115115 $inMessageGroup = TranslateUtils::messageKeyToGroup( $title->getNamespace(), $title->getBaseText() );
116116
Index: trunk/extensions/Translate/SpecialMagic.php
——@@ -633,7 +633,7 @@
634634 continue;
635635 } else {
636636 $text = $title->getText();
637 - $dbkey = $title->getDBKey();
 637+ $dbkey = $title->getDBkey();
638638 if( $text !== $_ && $dbkey !== $_ ) {
639639 $errors[] = "$_ is not in normalised form, which is $text or $dbkey";
640640 }
Index: trunk/extensions/CheckUser/CheckUser_body.php
——@@ -1085,7 +1085,7 @@
10861086 array( 'log_type' => array('block','suppress'),
10871087 'log_action' => 'block',
10881088 'log_namespace' => $userpage->getNamespace(),
1089 - 'log_title' => $userpage->getDBKey() ),
 1089+ 'log_title' => $userpage->getDBkey() ),
10901090 __METHOD__,
10911091 array( 'USE INDEX' => 'page_time' ) );
10921092 }

Status & tagging log