r50840 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50839‎ | r50840 | r50841 >
Date:22:21, 20 May 2009
Author:siebrand
Status:deferred
Tags:
Comment:
* remove trailing whitespace, update indentation, stylize.php
* bump version
Modified paths:
  • /trunk/extensions/Mibbit/Mibbit.i18n.php (modified) (history)
  • /trunk/extensions/Mibbit/Mibbit.php (modified) (history)
  • /trunk/extensions/Mibbit/Mibbit_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Mibbit/Mibbit_body.php
@@ -26,11 +26,11 @@
2727 'server' => $wgMibbitServer,
2828 'channel' => $wgMibbitChannel
2929 );
30 - if( $wgUser->isLoggedIn() ) $queryAssoc[ 'nick' ] = $wgUser->getName();
31 - if( $wgMibbitExtraParameters ) {
 30+ if ( $wgUser->isLoggedIn() ) $queryAssoc[ 'nick' ] = $wgUser->getName();
 31+ if ( $wgMibbitExtraParameters ) {
3232 $queryAssoc = array_merge( $queryAssoc, $wgMibbitExtraParameters );
3333 }
34 - foreach( $queryAssoc as $parameter => $value ) {
 34+ foreach ( $queryAssoc as $parameter => $value ) {
3535 $query[] = $parameter . '=' . urlencode( $value );
3636 }
3737 $queryString = implode( $query, '&' );
Index: trunk/extensions/Mibbit/Mibbit.i18n.php
@@ -17,7 +17,7 @@
1818 To connect simply press the "Connect" button.
1919 If you are logged in your nickname will have been prefilled.
2020 Anonymous users are given an automatically generated one, but it can be changed.',
21 - 'right-mibbit' => 'Allowed to use Mibbit chat',
 21+ 'right-mibbit' => 'Allowed to use Mibbit chat',
2222 );
2323
2424 /** Message documentation (Message documentation)
Index: trunk/extensions/Mibbit/Mibbit.php
@@ -1,5 +1,4 @@
22 <?php
3 -
43 /**
54 * Mibbit
65 *
@@ -15,7 +14,7 @@
1615 */
1716
1817 // If this is run directly from the web die as this is not a valid entry point.
19 -if( !defined( 'MEDIAWIKI' ) ) die( 'Invalid entry point.' );
 18+if ( !defined( 'MEDIAWIKI' ) ) die( 'Invalid entry point.' );
2019
2120 // Extension credits.
2221 $wgExtensionCredits[ 'specialpage' ][] = array(
@@ -25,7 +24,7 @@
2625 'descriptionmsg' => 'mibbit-desc',
2726 'author' => 'Robert Leverington',
2827 'url' => 'http://www.mediawiki.org/wiki/Extension:Mibbit',
29 - 'version' => '1.3.0',
 28+ 'version' => '1.3.1',
3029 );
3130
3231 // Register special page.

Status & tagging log