r50809 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50808‎ | r50809 | r50810 >
Date:04:30, 20 May 2009
Author:charlie
Status:resolved (Comments)
Tags:
Comment:
Follow-up to r50776. Retaining old method names for backwards compatibility,
but making them as deprecated. Patch by ^demon.
Modified paths:
  • /trunk/phase3/includes/AuthPlugin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/AuthPlugin.php
@@ -134,6 +134,33 @@
135135 }
136136
137137 /**
 138+ * Can users change their Real Name?
 139+ * @deprecated Use allowPropChange()
 140+ * @return bool
 141+ */
 142+ public function allowRealNameChange() {
 143+ return $this->allowPropChange( 'realname' );
 144+ }
 145+
 146+ /**
 147+ * Can users change their email address?
 148+ * @deprecated Use allowPropChange()
 149+ * @return bool
 150+ */
 151+ public function allowEmailChange() {
 152+ return $this->allowPropChange( 'emailaddress' );
 153+ }
 154+
 155+ /**
 156+ * Can users change their Nickname?
 157+ * @deprecated Use allowPropChange()
 158+ * @return bool
 159+ */
 160+ public function allowNickChange() {
 161+ return $this->allowPropChange( 'nickname' );
 162+ }
 163+
 164+ /**
138165 * Can users change their passwords?
139166 *
140167 * @return bool

Follow-up revisions

RevisionCommit summaryAuthorDate
r51669Oartial revert of r50809. Call the old method names for b/c.demon23:59, 9 June 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50776Per code review: Redo these allowBlah() functions (except allowPasswordChange...demon16:23, 19 May 2009

Comments

#Comment by Bryan (talk | contribs)   19:16, 22 May 2009

Should in some way also work the other way round, when AuthPlugins choose to override these methods to disallow nickchanges and similar.

#Comment by Simetrical (talk | contribs)   01:13, 26 May 2009

Yeah, this is sort of useless. The methods are never called. The Preferences.php changes in r50776 need to be reverted too.

#Comment by 😂 (talk | contribs)   00:00, 10 June 2009

Fixed in r51669.

Status & tagging log