r50767 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50766‎ | r50767 | r50768 >
Date:14:54, 19 May 2009
Author:demon
Status:ok
Tags:
Comment:
Code style tweak, use strval() to make this all much shorter.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialExport.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialExport.php
@@ -68,7 +68,7 @@
6969 $page = $wgRequest->getText( 'pages' );
7070 $nsindex = $wgRequest->getText( 'nsindex', '' );
7171
72 - if ( $nsindex !== '' && $nsindex !== null && $nsindex !== false ) {
 72+ if ( strval( $nsindex ) !== '' ) {
7373 /**
7474 * Same implementation as above, so same @fixme
7575 */

Status & tagging log