r50748 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r50747‎ | r50748 | r50749 >
Date:20:20, 18 May 2009
Author:brion
Status:ok
Tags:
Comment:
Follow-up to r50689 "* (bug 18389) Localise numbers in EXIF data (patch by Marcus Buck and Ahmad Sherif). Possible FIXME: Is said not to work for "Exif version" and fraction in "Exposure time""
Fixes the fraction formatting for the exposure time. Haven't actually seen anything with exif version?
Modified paths:
  • /trunk/phase3/includes/Exif.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Exif.php
——@@ -1109,7 +1109,7 @@
11101110 $gcd = $this->gcd( $numerator, $denominator );
11111111 if( $gcd != 0 ) {
11121112 // 0 shouldn't happen! ;)
1113 - return $numerator / $gcd . '/' . $denominator / $gcd;
 1113+ return $this->formatNum( $numerator / $gcd ) . '/' . $this->formatNum( $denominator / $gcd );
11141114 }
11151115 }
11161116 return $this->formatNum( $num );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50689* (bug 18389) Localise numbers in EXIF data (patch by Marcus Buck and Ahmad S...siebrand14:34, 17 May 2009

Status & tagging log