r50702 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50701‎ | r50702 | r50703 >
Date:17:55, 17 May 2009
Author:siebrand
Status:ok
Tags:
Comment:
(bug 18438) Tweak HTML for preview bar for consistency and accessibility (patch contributed by Happy-melon with tweaks by siebrand)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -1242,16 +1242,13 @@
12431243 }
12441244
12451245 .previewnote {
1246 - text-indent: 3em;
12471246 color: #c00;
1248 - border-bottom: 1px solid #aaa;
1249 - padding-bottom: 1em;
12501247 margin-bottom: 1em;
12511248 }
12521249
12531250 .previewnote p {
1254 - margin: 0;
1255 - padding: 0;
 1251+ text-indent: 3em;
 1252+ margin: 0.8em 0;
12561253 }
12571254
12581255 .editExternally {
Index: trunk/phase3/includes/EditPage.php
@@ -1797,12 +1797,16 @@
17981798 }
17991799 }
18001800
1801 - $previewhead = '<h2>' . htmlspecialchars( wfMsg( 'preview' ) ) . "</h2>\n" .
1802 - "<div class='previewnote'>" . $wgOut->parse( $note ) . "</div>\n";
1803 - if ( $this->isConflict ) {
1804 - $previewhead .='<h2>' . htmlspecialchars( wfMsg( 'previewconflict' ) ) . "</h2>\n";
 1801+ if( $this->isConflict ) {
 1802+ $conflict = '<h2 id="mw-previewconflict">' . htmlspecialchars( wfMsg( 'previewconflict' ) ) . "</h2>\n";
 1803+ } else {
 1804+ $conflict = '<hr />';
18051805 }
18061806
 1807+ $previewhead = "<div class='previewnote'>\n" .
 1808+ '<h2 id="mw-previewheader">' . htmlspecialchars( wfMsg( 'preview' ) ) . "</h2>" .
 1809+ $wgOut->parse( $note ) . $conflict . "</div>\n";
 1810+
18071811 wfProfileOut( __METHOD__ );
18081812 return $previewhead . $previewHTML;
18091813 }
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1479,7 +1479,7 @@
14801480 * to ensure that client-side caches don't keep obsolete copies of global
14811481 * styles.
14821482 */
1483 -$wgStyleVersion = '218';
 1483+$wgStyleVersion = '219';
14841484
14851485
14861486 # Server-side caching:
Index: trunk/phase3/RELEASE-NOTES
@@ -127,6 +127,7 @@
128128 * (bug 16912) Tooltips on images with link= disappear
129129 * (bug 18389) Localise numbers in EXIF data
130130 * (bug 18522) Wrap MediaWiki:Protect-cascadeon in a div for identification
 131+* (bug 18438) Tweak HTML for preview bar for consistency and accessibility
131132
132133 == API changes in 1.16 ==
133134

Status & tagging log