r50618 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50617‎ | r50618 | r50619 >
Date:04:00, 15 May 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Backported r49142, bug 18170, fixed a PHP warning in Parser::preSaveTransform() in PHP 5.3
Modified paths:
  • /branches/REL1_15/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_15/phase3/includes/parser (modified) (history)
  • /branches/REL1_15/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: branches/REL1_15/phase3/includes/parser/Parser.php
@@ -3689,13 +3689,13 @@
36903690 *
36913691 * @param string $text the text to transform
36923692 * @param Title &$title the Title object for the current article
3693 - * @param User &$user the User object describing the current user
 3693+ * @param User $user the User object describing the current user
36943694 * @param ParserOptions $options parsing options
36953695 * @param bool $clearState whether to clear the parser state first
36963696 * @return string the altered wiki markup
36973697 * @public
36983698 */
3699 - function preSaveTransform( $text, &$title, $user, $options, $clearState = true ) {
 3699+ function preSaveTransform( $text, Title $title, $user, $options, $clearState = true ) {
37003700 $this->mOptions = $options;
37013701 $this->setTitle( $title );
37023702 $this->setOutputType( self::OT_WIKI );
Property changes on: branches/REL1_15/phase3/includes/parser
___________________________________________________________________
Name: svn:mergeinfo
37033703 + /trunk/phase3/includes/parser:48836,48886,48892,48989,48992,49002,49051,49068,49086,49142,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50470
/trunk/phase3/includes/specials/parser:48993
Index: branches/REL1_15/phase3/RELEASE-NOTES
@@ -300,7 +300,9 @@
301301 * (bug 11451) Fix upgrade from MediaWiki 1.2 or earlier (imagelinks schema).
302302 * Fixed SQLite indexes, installation and upgrade. Reintroduced it as an option
303303 to the installer.
 304+* (bug 18170) Fixed a PHP warning in Parser::preSaveTransform() in PHP 5.3
304305
 306+
305307 == API changes in 1.15 ==
306308 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions
307309 and listing all deleted pages possible

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49142* (bug 18170) Fixed a PHP warning in Parser::preSaveTransform() in PHP 5.3: P...ialex19:16, 2 April 2009

Status & tagging log