r50616 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50615‎ | r50616 | r50617 >
Date:03:11, 15 May 2009
Author:tstarling
Status:deferred
Tags:
Comment:
* Backported r50614: SQLite ResultWrapper fix. Noted SQLite reintroduction in RELEASE-NOTES.
Modified paths:
  • /branches/REL1_15/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_15/phase3/includes/db (modified) (history)
  • /branches/REL1_15/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: branches/REL1_15/phase3/includes/db/Database.php
@@ -2760,7 +2760,7 @@
27612761 * Get the number of rows in a result object
27622762 */
27632763 function numRows() {
2764 - return $this->db->numRows( $this->result );
 2764+ return $this->db->numRows( $this );
27652765 }
27662766
27672767 /**
@@ -2773,7 +2773,7 @@
27742774 * @throws DBUnexpectedError Thrown if the database returns an error
27752775 */
27762776 function fetchObject() {
2777 - return $this->db->fetchObject( $this->result );
 2777+ return $this->db->fetchObject( $this );
27782778 }
27792779
27802780 /**
@@ -2785,14 +2785,14 @@
27862786 * @throws DBUnexpectedError Thrown if the database returns an error
27872787 */
27882788 function fetchRow() {
2789 - return $this->db->fetchRow( $this->result );
 2789+ return $this->db->fetchRow( $this );
27902790 }
27912791
27922792 /**
27932793 * Free a result object
27942794 */
27952795 function free() {
2796 - $this->db->freeResult( $this->result );
 2796+ $this->db->freeResult( $this );
27972797 unset( $this->result );
27982798 unset( $this->db );
27992799 }
@@ -2802,7 +2802,7 @@
28032803 * See mysql_data_seek()
28042804 */
28052805 function seek( $row ) {
2806 - $this->db->dataSeek( $this->result, $row );
 2806+ $this->db->dataSeek( $this, $row );
28072807 }
28082808
28092809 /*********************
@@ -2813,7 +2813,7 @@
28142814
28152815 function rewind() {
28162816 if ($this->numRows()) {
2817 - $this->db->dataSeek($this->result, 0);
 2817+ $this->db->dataSeek($this, 0);
28182818 }
28192819 $this->pos = 0;
28202820 $this->currentRow = null;
Property changes on: branches/REL1_15/phase3/includes/db
___________________________________________________________________
Name: svn:mergeinfo
28212821 - /trunk/phase3/includes/db:48836,48886,48892,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50473,50580
/trunk/phase3/includes/specials/db:48993
28222822 + /trunk/phase3/includes/db:48836,48886,48892,48989,48992,49002,49051,49068,49086,49191-49192,49212,49682,49685,49730,49775,49954,49956,49999,50041,50054,50070,50132,50134,50169,50215,50218,50328,50473,50580,50614
/trunk/phase3/includes/specials/db:48993
Index: branches/REL1_15/phase3/RELEASE-NOTES
@@ -298,6 +298,8 @@
299299 * (bug 16937) Fixed PostgreSQL installation on Windows, workaround for upstream
300300 pg_version() bug.
301301 * (bug 11451) Fix upgrade from MediaWiki 1.2 or earlier (imagelinks schema).
 302+* Fixed SQLite indexes, installation and upgrade. Reintroduced it as an option
 303+ to the installer.
302304
303305 == API changes in 1.15 ==
304306 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50614Fix breakage of SQLite ResultWrapper due to r45769. The "result" member in SQ...tstarling02:49, 15 May 2009

Status & tagging log