r50608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50607‎ | r50608 | r50609 >
Date:22:43, 14 May 2009
Author:brion
Status:ok
Tags:
Comment:
Cleanup for r50567:
* Include DB table options on log_search table creation
* Adjust tabs->spaces in table def... sounds silly, but the tabs sometimes confuse things when cut-and-pasting into mysql command line. :)
Modified paths:
  • /trunk/phase3/maintenance/archives/patch-log_search.sql (modified) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/archives/patch-log_search.sql
@@ -1,10 +1,10 @@
22 CREATE TABLE /*_*/log_search (
3 - -- The type of ID (rev ID, log ID, rev timestamp, username)
4 - ls_field varbinary(32) NOT NULL,
5 - -- The value of the ID
6 - ls_value varchar(255) NOT NULL,
7 - -- Key to log_id
8 - ls_log_id int unsigned NOT NULL default 0,
9 - PRIMARY KEY (ls_field,ls_value,ls_log_id)
10 -);
 3+ -- The type of ID (rev ID, log ID, rev timestamp, username)
 4+ ls_field varbinary(32) NOT NULL,
 5+ -- The value of the ID
 6+ ls_value varchar(255) NOT NULL,
 7+ -- Key to log_id
 8+ ls_log_id int unsigned NOT NULL default 0,
 9+ PRIMARY KEY (ls_field,ls_value,ls_log_id)
 10+) /*$wgDBTableOptions*/;
1111 CREATE INDEX /*i*/ls_log_id ON /*_*/log_search (ls_log_id);
Index: trunk/phase3/maintenance/tables.sql
@@ -1125,14 +1125,14 @@
11261126
11271127
11281128 CREATE TABLE /*_*/log_search (
1129 - -- The type of ID (rev ID, log ID, rev timestamp, username)
1130 - ls_field varbinary(32) NOT NULL,
1131 - -- The value of the ID
1132 - ls_value varchar(255) NOT NULL,
1133 - -- Key to log_id
1134 - ls_log_id int unsigned NOT NULL default 0,
1135 - PRIMARY KEY (ls_field,ls_value,ls_log_id)
1136 -);
 1129+ -- The type of ID (rev ID, log ID, rev timestamp, username)
 1130+ ls_field varbinary(32) NOT NULL,
 1131+ -- The value of the ID
 1132+ ls_value varchar(255) NOT NULL,
 1133+ -- Key to log_id
 1134+ ls_log_id int unsigned NOT NULL default 0,
 1135+ PRIMARY KEY (ls_field,ls_value,ls_log_id)
 1136+) /*$wgDBTableOptions*/;
11371137 CREATE INDEX /*i*/ls_log_id ON /*_*/log_search (ls_log_id);
11381138
11391139

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50567[schema change] Use new log_search table to replace ugly code from r48839. Ma...aaron22:03, 13 May 2009

Status & tagging log