r50602 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50601‎ | r50602 | r50603 >
Date:20:45, 14 May 2009
Author:demon
Status:ok
Tags:
Comment:
(bug 18656) Use proper directory separators in wfMkdirParents(). Normalized all \ or / to DIRECTORY_SEPARATOR.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2064,6 +2064,8 @@
20652065 if( strval( $dir ) === '' || file_exists( $dir ) )
20662066 return true;
20672067
 2068+ $dir = str_replace( array( '\\', '/' ), DIRECTORY_SEPARATOR, $dir );
 2069+
20682070 if ( is_null( $mode ) )
20692071 $mode = $wgDirectoryMode;
20702072
Index: trunk/phase3/RELEASE-NOTES
@@ -117,6 +117,7 @@
118118 * (bug 18718) Comma after a } create a error in IE
119119 * (bug 18716) Removed redundant class in Modern skin CSS for category links and
120120 tweaked spacing.
 121+* (bug 18656) Use proper directory separators in wfMkdirParents()
121122
122123 == API changes in 1.16 ==
123124

Status & tagging log