r50568 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50567‎ | r50568 | r50569 >
Date:22:22, 13 May 2009
Author:aaron
Status:ok
Tags:
Comment:
Give failure message rather than assuming field 0 for trying to set field 8 (just suppressing a rev but not hiding anything)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -851,7 +851,7 @@
852852 $dbw = wfGetDB( DB_MASTER );
853853 // Don't allow simply locking the interface for no reason
854854 if( $bitfield == Revision::DELETED_RESTRICTED ) {
855 - $bitfield = 0;
 855+ return false;
856856 }
857857 $deleter = new RevisionDeleter( $dbw );
858858 // By this point, only one of the below should be set

Status & tagging log