r50545 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50544‎ | r50545 | r50546 >
Date:15:37, 13 May 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
* Some questions/notes for r50543
Modified paths:
  • /trunk/extensions/AdminLinks/AdminLinks.i18n.php (modified) (history)
  • /trunk/extensions/AdminLinks/AdminLinks.php (modified) (history)
  • /trunk/extensions/AdminLinks/AdminLinks_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AdminLinks/AdminLinks.php
@@ -30,3 +30,4 @@
3131 = $wgAutoloadClasses['ALRow']
3232 = $wgAutoloadClasses['ALItem']
3333 = "$wgAdminLinksIP/AdminLinks_body.php";
 34+//Q: add $wgExtensionAliasesFiles ?
Index: trunk/extensions/AdminLinks/AdminLinks_body.php
@@ -39,6 +39,8 @@
4040 $users_section = new ALSection(wfMsg('adminlinks_users'));
4141 $main_row = new ALRow('main');
4242 $main_row->addItem(ALItem::newFromSpecialPage('Listusers'));
 43+ //Q: Use SpecialPage::getTitleFor() ?
 44+ //Q: Special:HelpfulLinks ?
4345 $ul = SpecialPage::getPage('Userlogin');
4446 $main_row->addItem(AlItem::newFromPage($ul->getTitle(), wfMsg('adminlinks_createuser'), 'type=signup&returnto=Special:HelpfulLinks'));
4547 $main_row->addItem(ALItem::newFromSpecialPage('Userrights'));
@@ -268,6 +270,8 @@
269271 $item->label = $page_name;
270272 $title = Title::makeTitleSafe(NS_MEDIAWIKI, $page_name);
271273 $edit_link = $title->getFullURL('action=edit');
 274+ //Q: raw html message and parameter?
 275+ //Q: translators need to know what is $1, and most likely they still have problems translating constructions like "Edit $1"
272276 $full_desc = wfMsg('adminlinks_edit', $desc);
273277 $item->text = "<a href=\"$edit_link\">$full_desc</a>";
274278 return $item;
Index: trunk/extensions/AdminLinks/AdminLinks.i18n.php
@@ -14,7 +14,7 @@
1515 */
1616 $messages['en'] = array(
1717 'adminlinks' => 'Admin links',
18 - 'adminlinks_documentation' => '$1 documentation',
 18+ 'adminlinks_documentation' => '$1 documentation', //FIXME: unused message? NB: try to avoid lego
1919 'adminlinks_edit' => 'Edit $1',
2020 'adminlinks_general' => 'General',
2121 'adminlinks_sidebar' => 'sidebar',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50543New extension: AdminLinksyaron14:42, 13 May 2009

Status & tagging log