r50493 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50492‎ | r50493 | r50494 >
Date:17:13, 11 May 2009
Author:dale
Status:deferred
Tags:
Comment:
updated testing page
fixed broken secure json reference
commented out front-loading of future clips while still under development
Modified paths:
  • /trunk/extensions/MetavidWiki/skins/mv_embed/example_usage/testing_page.php (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/libAddMedia/mvUploader.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/libEmbedVideo/mv_omtkEmbed.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/libSequencer/mvPlayList.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/skins/mv_embed/example_usage/testing_page.php
@@ -18,7 +18,7 @@
1919 <table border="1" cellpadding="6" width="600">
2020 <tr>
2121 <td valign="top">
22 - <video src="test_audio.oga" type="audio/ogg"></video>
 22+ <playlist src="fresh_smil_load.php" type="audio/ogg"></playlist>
2323 </td>
2424 <td valign="top"><b>Test embed</b><br />
2525 </td>
Index: trunk/extensions/MetavidWiki/skins/mv_embed/libAddMedia/mvUploader.js
@@ -329,7 +329,7 @@
330330 if(typeof JSON == 'undefined'){
331331 //we need to load the jQuery json parser: (older browsers don't have JSON.parse
332332 mvJsLoader.doLoad({
333 - '$.secureEvalJSON':'jquery/plugins/jquery.json-1.3.js'
 333+ '$j.secureEvalJSON':'jquery/plugins/jquery.json-1.3.js'
334334 },function(){
335335 var apiResult = $j.secureEvalJSON( data.upload['apiUploadResult'] );
336336 _this.processApiResult( apiResult );
Index: trunk/extensions/MetavidWiki/skins/mv_embed/libSequencer/mvPlayList.js
@@ -532,7 +532,7 @@
533533 * this won't work so well with time range loading for smil (need to work on that)
534534 */
535535 loadFutureClips:function(){
536 - if( this.cur_clip.embed.bufferedPercent == 1){
 536+ /*if( this.cur_clip.embed.bufferedPercent == 1){
537537 //set the buffer to the currentTime - duration
538538 var curBuffredTime = this.cur_clip.getDuration() - this.cur_clip.embed.currentTime;
539539
@@ -543,7 +543,7 @@
544544 if( curBuffredTime < this.playlist_buffer_time ){
545545 js_log(" we only have " + curBuffredTime + ' buffed but we need: ' + this.playlist_buffer_time);
546546
547 - for(var inx = this.cur_clip.order + 1; inx < this.default_track.clip.length; inx++ ){
 547+ for(var inx = this.cur_clip.order + 1; inx < this.default_track.clips.length; inx++ ){
548548 var cClip = this.default_track.getClip( inx );
549549
550550 //check if the clip is already loaded (add its duration)
@@ -560,7 +560,7 @@
561561 }
562562 }
563563 }
564 - }
 564+ }*/
565565 },
566566 //called to play the next clip if done call onClipDone
567567 playNext: function(){
Index: trunk/extensions/MetavidWiki/skins/mv_embed/libEmbedVideo/mv_omtkEmbed.js
@@ -7,13 +7,13 @@
88 getEmbedHTML : function (){
99 var embed_code = this.getEmbedObj();
1010 //need omtk to fire an onReady event.
11 - setTimeout('$j(\'#' + this.id + '\').get(0).postEmbedJS()', 1000);
 11+ setTimeout('$j(\'#' + this.id + '\').get(0).postEmbedJS()', 2000);
1212 return this.wrapEmebedContainer( embed_code);
1313 },
1414 getEmbedObj:function(){
15 - var player_path = mv_embed_path + 'binPlayers/omtk-fx/omtkp.swf';
 15+ var player_path = mv_embed_path + 'binPlayers/omtk-fx/omtkp.swf';
 16+ //player_path = 'omtkp.swf';
1617 js_log("player path: " + player_path);
17 - //player_path = 'omtkp.swf';
1818 return '<object id="'+this.pid+'" classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" width="1" height="1">' +
1919 '<param name="movie" value="' + player_path +'" />'+"\n"+
2020 '<!--[if !IE]>-->'+"\n"+

Status & tagging log