r50459 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50458‎ | r50459 | r50460 >
Date:20:33, 10 May 2009
Author:vyznev
Status:reverted (Comments)
Tags:
Comment:
fix regression from r49677 by refusing to format old-style metadata even if a foreign repo hands us some
Modified paths:
  • /trunk/phase3/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Bitmap.php
@@ -320,6 +320,16 @@
321321 if ( !$exif ) {
322322 return false;
323323 }
 324+ if ( !isset( $exif['MEDIAWIKI_EXIF_VERSION'] ) ||
 325+ $exif['MEDIAWIKI_EXIF_VERSION'] != Exif::version() )
 326+ {
 327+ // XXX: This should be caught by isMetadataValid(), but
 328+ // some non-local repos might call this function without
 329+ // checking validity, causing FormatExif to barf, so we
 330+ // check it again just to be sure.
 331+ wfDebug( __METHOD__.": wrong version\n" );
 332+ return false;
 333+ }
324334 unset( $exif['MEDIAWIKI_EXIF_VERSION'] );
325335 $format = new FormatExif( $exif );
326336

Follow-up revisions

RevisionCommit summaryAuthorDate
r51540Revert r49677, r50459, Brent G's patch for fixing GPS coordinates in EXIF. As...tstarling15:48, 6 June 2009
r51557Follow up to r51540 (revert r49677, r50459): global $wgLang was missing causi...siebrand22:04, 6 June 2009
r51562Follow-up to r51540 (revert r49677, r50459): also revert changes to messages.incsiebrand10:46, 7 June 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49677Apply patch for bug 13172 by Brent G <overlordq@gmail.com> with minor modific...vyznev22:29, 20 April 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   16:59, 11 May 2009

This seems like a bad idea; it would appear to require that every client use the exact same version of MediaWiki as the repo.

Status & tagging log