r50452 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50451‎ | r50452 | r50453 >
Date:19:05, 10 May 2009
Author:siebrand
Status:deferred
Tags:
Comment:
* add localisation support for extension description. FIXME: for English a variable is used; currently not supported for localised descriptions.
* Format authors in extension credits as array
Modified paths:
  • /trunk/extensions/SemanticResultFormats/SRF_Messages.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/SRF_Settings.php (modified) (history)
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/SRF_Settings.php
@@ -32,9 +32,10 @@
3333 'path' => __FILE__,
3434 'name' => 'Semantic Result Formats',
3535 'version' => SRF_VERSION,
36 - 'author' => "Frank Dengler, [http://steren.fr Steren Giannini], Fabian Howahl, Yaron Koren, [http://korrekt.org Markus Krötzsch], David Loomer, Joel Natividad, [http://simia.net Denny Vrandecic], Nathan Yergler",
 36+ 'author' => array( 'Frank Dengler', '[http://steren.fr Steren Giannini]', 'Fabian Howahl', 'Yaron Koren', '[http://korrekt.org Markus Krötzsch]', 'David Loomer', 'Joel Natividad', '[http://simia.net Denny Vrandecic]', 'Nathan Yergler' ),
3737 'url' => 'http://semantic-mediawiki.org/wiki/Help:Semantic_Result_Formats',
38 - 'description' => 'Additional formats for Semantic MediaWiki inline queries. Available formats: ' . $formats_list
 38+ 'description' => 'Additional formats for Semantic MediaWiki inline queries. Available formats: ' . $formats_list,
 39+ 'descriptionmsg' => 'srf-desc'
3940 );
4041 }
4142
Index: trunk/extensions/SemanticResultFormats/SRF_Messages.php
@@ -10,6 +10,8 @@
1111 /** English
1212 */
1313 $messages['en'] = array(
 14+ 'srf-desc' => 'Additional formats for Semantic MediaWiki inline queries', // FIXME: descmsg in extension credits should allow for parameter(s) so that $formats_list can be added
 15+
1416 // user messages
1517 // format "calendar"
1618 'srfc_previousmonth' => 'Previous month',
Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
@@ -675,6 +675,7 @@
676676
677677 Semantic Result Formats
678678 file = SemanticResultFormats/SRF_Messages.php
 679+descmsg = srf-desc
679680 optional = srf_icalendar_link, srf_vcard_link, srf_bibtex_link
680681
681682 Semantic Drilldown

Status & tagging log