r50420 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50419‎ | r50420 | r50421 >
Date:09:18, 10 May 2009
Author:catrope
Status:ok
Tags:
Comment:
Revert r50180 ("Proper error message on action=protect"): causes bug 18728 ("Non-admins can no longer see protection settings")
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1962,16 +1962,6 @@
19631963 * action=protect handler
19641964 */
19651965 public function protect() {
1966 - global $wgUser, $wgOut;
1967 -
1968 - # Check permissions
1969 - $permission_errors = $this->mTitle->getUserPermissionsErrors( 'protect', $wgUser );
1970 -
1971 - if( count( $permission_errors ) > 0 ) {
1972 - $wgOut->showPermissionsErrorPage( $permission_errors );
1973 - return;
1974 - }
1975 -
19761966 $form = new ProtectionForm( $this );
19771967 $form->execute();
19781968 }
Index: trunk/phase3/RELEASE-NOTES
@@ -110,8 +110,6 @@
111111 * Removed float from the user login form in RTL interface - caused display
112112 problems in FF2
113113 * (bug 15008) Redirect images are now subject to Bad image list rules
114 -* (bug 18677) Give proper error message when viewing &action=protect without
115 - sufficient rights
116114 * (bug 6802) profileinfo.php now also work on other database servers than MySQL
117115 * (bug 16925) Diffs no longer fail when $wgExternalDiffEngine is set to 'wikidiff'
118116 or 'wikidiff2' but extension is not installed

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50180(bug 18677) Give proper error message when viewing &action=protect without su...catrope14:51, 4 May 2009

Status & tagging log