r50319 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50318‎ | r50319 | r50320 >
Date:20:02, 7 May 2009
Author:demon
Status:ok
Tags:
Comment:
Don't explicitly check for false. Most modules without params return an empty array rather than false, in which case we still don't want to output this.
Modified paths:
  • /trunk/phase3/includes/api/ApiBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiBase.php
@@ -272,7 +272,7 @@
273273 */
274274 public function makeHelpMsgParameters() {
275275 $params = $this->getFinalParams();
276 - if ($params !== false) {
 276+ if ( $params ) {
277277
278278 $paramsDescription = $this->getFinalParamDescription();
279279 $msg = '';

Status & tagging log