r50315 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50314‎ | r50315 | r50316 >
Date:16:51, 7 May 2009
Author:ialex
Status:ok
Tags:
Comment:
fix E_PARSE from r50310
Modified paths:
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -623,7 +623,7 @@
624624 */
625625 private function initDiffEngines() {
626626 global $wgExternalDiffEngine;
627 - if ( $wgExternalDiffEngine == 'wikidiff' && !function_exists( 'wikidiff_do_diff' ) {
 627+ if ( $wgExternalDiffEngine == 'wikidiff' && !function_exists( 'wikidiff_do_diff' ) ) {
628628 wfProfileIn( __METHOD__ . '-php_wikidiff.so' );
629629 @dl( 'php_wikidiff.so' );
630630 wfProfileOut( __METHOD__ . '-php_wikidiff.so' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r50310(bug 16925) Diffs no longer silently fail when $wgExternalDiffEngine is set t...demon16:00, 7 May 2009

Status & tagging log