r50149 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50148‎ | r50149 | r50150 >
Date:05:36, 3 May 2009
Author:river
Status:deferred
Tags:
Comment:
- 1.6
- use getline instead of >> so we read the entire command line
Modified paths:
  • /trunk/tools/slayerd/debian/changelog (modified) (history)
  • /trunk/tools/slayerd/slayerd.cc (modified) (history)

Diff [purge]

Index: trunk/tools/slayerd/slayerd.cc
@@ -21,6 +21,7 @@
2222 #include <map>
2323 #include <set>
2424 #include <cerrno>
 25+#include <cstring>
2526
2627 #include <sys/types.h>
2728 #include <sys/mman.h>
@@ -174,7 +175,7 @@
175176 if (!f)
176177 throw std::runtime_error("could not read line from cmdline");
177178
178 - if (!(f >> _fullcomm))
 179+ if (!std::getline(f, _fullcomm))
179180 throw std::runtime_error("could not parse cmdline");
180181 }
181182 }
Index: trunk/tools/slayerd/debian/changelog
@@ -1,3 +1,9 @@
 2+slayerd (1.6) unstable; urgency=low
 3+
 4+ * Include the full command line in the mail message.
 5+
 6+ -- River Tarnell <river@loreley.flyingparchment.org.uk> Sun, 03 May 2009 05:35:21 +0000
 7+
28 slayerd (1.5) unstable; urgency=low
39
410 * "data" figure appears non-useful, go back to RSS.

Status & tagging log