r50104 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50103‎ | r50104 | r50105 >
Date:12:55, 1 May 2009
Author:werdna
Status:ok
Tags:
Comment:
Sanitize class names applied by change tagging -- was not anticipating multi-word, ugly tag names
Modified paths:
  • /trunk/phase3/includes/ChangeTags.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangeTags.php
@@ -14,7 +14,7 @@
1515 $displayTags = array();
1616 foreach( $tags as $tag ) {
1717 $displayTags[] = self::tagDescription( $tag );
18 - $classes[] = "mw-tag-$tag";
 18+ $classes[] = Sanitizer::escapeClass( "mw-tag-$tag" );
1919 }
2020
2121 return array( '(' . implode( ', ', $displayTags ) . ')', $classes );

Status & tagging log