r50069 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r50068‎ \| r50069 \| r50070 >
Date:	06:00, 30 April 2009
Author:	tstarling
Status:	deferred
Tags:
Comment:	Small-scale data loss logged on Wikimedia along these lines: invalid URL written to old_text with the user thinking their edit has succeeded. This change should prevent that scenario.
Modified paths:	/trunk/phase3/includes/ExternalStoreDB.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ExternalStoreDB.php
—	—	@@ -136,6 +136,9 @@
137	137	array( 'blob_id' => $id, 'blob_text' => $data ),
138	138	__METHOD__ );
139	139	$id = $dbw->insertId();
	140	+ if ( !$id ) {
	141	+ throw new MWException( __METHOD__.': no insert ID' );
	142	+ }
140	143	if ( $dbw->getFlag( DBO_TRX ) ) {
141	144	$dbw->immediateCommit();
142	145	}

18:03, 9 December 2011 Aaron Schulz (talk | contribs) changed the tags for r50069 [removed: ok]
07:09, 19 May 2009 Tim Starling (talk | contribs) changed the status of r50069 [removed: new added: deferred]
00:15, 6 May 2009 Brion VIBBER (talk | contribs) changed the status of r50069 [removed: new added: ok]
06:23, 30 April 2009 Aaron Schulz (talk | contribs) changed the tags for r50069 [added: ok]