r50031 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r50030‎ | r50031 | r50032 >
Date:00:01, 29 April 2009
Author:werdna
Status:ok
Tags:
Comment:
Fix alignment of prefs buttons in standard and cologneblue
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)
  • /trunk/phase3/skins/common/oldshared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/oldshared.css
@@ -159,7 +159,7 @@
160160 display: block;
161161 color: #005189;
162162 }
163 -#prefcontrol {
 163+.mw-prefs-buttons {
164164 clear: left;
165165 float: left;
166166 margin-top: 1em;
Index: trunk/phase3/includes/Preferences.php
@@ -822,7 +822,16 @@
823823 'label-message' => 'contextchars',
824824 'section' => 'searchoptions',
825825 'min' => 0,
826 - );
 826+ );
 827+ global $wgEnableMWSuggest;
 828+ if ($wgEnableMWSuggest) {
 829+ $defaultPreferences['disablesuggest'] =
 830+ array(
 831+ 'type' => 'toggle',
 832+ 'label-message' => 'mwsuggest-disable',
 833+ 'section' => 'searchoptions',
 834+ );
 835+ }
827836
828837 // Searchable namespaces back-compat with old format
829838 $searchableNamespaces = SearchEngine::searchableNamespaces();
@@ -845,16 +854,6 @@
846855 'section' => 'searchoptions',
847856 'prefix' => 'searchNs',
848857 );
849 -
850 - global $wgEnableMWSuggest;
851 - if ($wgEnableMWSuggest) {
852 - $defaultPreferences['disablesuggest'] =
853 - array(
854 - 'type' => 'toggle',
855 - 'label-message' => 'mwsuggest-disable',
856 - 'section' => 'searchoptions',
857 - );
858 - }
859858 }
860859
861860 static function miscPreferences( $user, &$defaultPreferences ) {
@@ -1222,6 +1221,8 @@
12231222
12241223 $html .= "\n" . $sk->link( $t, wfMsg( 'restoreprefs' ) );
12251224
 1225+ $html = Xml::tags( 'div', array( 'class' => 'mw-prefs-buttons' ), $html );
 1226+
12261227 return $html;
12271228 }
12281229

Status & tagging log