r49964 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49963‎ | r49964 | r49965 >
Date:17:41, 27 April 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r49957 "Move math preferences into rendering, to minimise number of tabs"
Made the page rendering tab cluttered and confusing; no clear separation between this plugin feature and other things around it.
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -17,6 +17,7 @@
1818
1919 self::profilePreferences( $user, $defaultPreferences );
2020 self::skinPreferences( $user, $defaultPreferences );
 21+ self::mathPreferences( $user, $defaultPreferences );
2122 self::filesPreferences( $user, $defaultPreferences );
2223 self::datetimePreferences( $user, $defaultPreferences );
2324 self::renderingPreferences( $user, $defaultPreferences );
@@ -390,6 +391,21 @@
391392 }
392393 }
393394
 395+ static function mathPreferences( $user, &$defaultPreferences ) {
 396+ ## Math #####################################
 397+ global $wgUseTeX, $wgLang;
 398+ if ($wgUseTeX) {
 399+ $defaultPreferences['math'] =
 400+ array(
 401+ 'type' => 'radio',
 402+ 'options' =>
 403+ array_flip( array_map( 'wfMsg', $wgLang->getMathNames() ) ),
 404+ 'label' => ' ',
 405+ 'section' => 'math',
 406+ );
 407+ }
 408+ }
 409+
394410 static function filesPreferences( $user, &$defaultPreferences ) {
395411 ## Files #####################################
396412 $defaultPreferences['imagesize'] =
@@ -494,20 +510,6 @@
495511 'options' => $stubThresholdOptions,
496512 'label' => wfMsg('stub-threshold'), // Raw HTML message. Yay?
497513 );
498 -
499 - ## Math
500 - global $wgUseTeX, $wgLang;
501 - if ($wgUseTeX) {
502 - $defaultPreferences['math'] =
503 - array(
504 - 'type' => 'radio',
505 - 'options' =>
506 - array_flip( array_map( 'wfMsg', $wgLang->getMathNames() ) ),
507 - 'label' => ' ',
508 - 'section' => 'rendering',
509 - );
510 - }
511 -
512514 $defaultPreferences['highlightbroken'] =
513515 array(
514516 'type' => 'toggle',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49957Move math preferences into rendering, to minimise number of tabswerdna14:22, 27 April 2009

Status & tagging log