r49945 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49944‎ | r49945 | r49946 >
Date:12:04, 27 April 2009
Author:werdna
Status:ok
Tags:
Comment:
Clean up remnants from half-done solutions in r49925, per comments on code review
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -282,7 +282,7 @@
283283 # Try cache
284284 $key = wfMemcKey( 'user', 'id', $this->mId );
285285 $data = $wgMemc->get( $key );
286 - if ( !is_array( $data ) || $data['mVersion'] < 'MW_USER_VERSION' ) {
 286+ if ( !is_array( $data ) || $data['mVersion'] < MW_USER_VERSION ) {
287287 # Object is expired, load from DB
288288 $data = false;
289289 }
@@ -972,7 +972,7 @@
973973 $this->mSkin = null;
974974 $this->mRights = null;
975975 $this->mEffectiveGroups = null;
976 - $this->mOptions = array();
 976+ $this->mOptions = null;
977977
978978 if ( $reloadFrom ) {
979979 $this->mDataLoaded = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49925Fix problem where cached user objects would not update when default user opti...werdna03:51, 27 April 2009

Status & tagging log