r49848 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49847‎ | r49848 | r49849 >
Date:23:11, 24 April 2009
Author:demon
Status:ok
Tags:
Comment:
(bug 18571) Purging image should always clear metadata cache. Sometimes the metadata is stale and the image does in fact exist. Patch by nephele.
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -83,6 +83,7 @@
8484 * Mormegil
8585 * Nakon
8686 * Nathan Larson
 87+* nephele
8788 * Nikolaos S. Karastathis
8889 * Olaf Lenz
8990 * Paul Copperman
Index: trunk/phase3/includes/ImagePage.php
@@ -697,7 +697,10 @@
698698 $this->img->upgradeRow();
699699 $this->img->purgeCache();
700700 } else {
701 - wfDebug( "ImagePage::doPurge no image\n" );
 701+ wfDebug( "ImagePage::doPurge no image for " . $this->img->getName() . "; limiting purge to cache only\n" );
 702+ // even if the file supposedly doesn't exist, force any cached information
 703+ // to be updated (in case the cached information is wrong)
 704+ $this->img->purgeCache();
702705 }
703706 parent::doPurge();
704707 }
Index: trunk/phase3/RELEASE-NOTES
@@ -360,12 +360,13 @@
361361 revisions when --delete is not passed
362362 * (bug 13172) GPS coordinates in image Exif data are now actually displayed
363363 * Overhaul of preferences system, includes the following bug fixes:
364 - * (bug 5363) Changes to default preferences now impact registered users.
365 - * (bug 14806) Hook to enable putting preferences in existing tabs.
366 - * (bug 17191) Registration date now listed on preferences page.
367 - * Note that this change will break some extensions which have not been adapted
368 - for it.
369 -* (bug 17020) Adding fallback encodings for Traditional and Simplified Chinese languages while the the text is typed as URLs.
 364+* (bug 5363) Changes to default preferences now impact registered users.
 365+* (bug 14806) Hook to enable putting preferences in existing tabs.
 366+* (bug 17191) Registration date now listed on preferences page.
 367+* Note that this change will break some extensions which have not been adapted
 368+ for it.
 369+* (bug 17020) Adding fallback encodings for Traditional and Simplified Chinese
 370+ languages while the the text is typed as URLs.
370371
371372 == API changes in 1.15 ==
372373 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Status & tagging log