r49807 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49806‎ | r49807 | r49808 >
Date:09:02, 24 April 2009
Author:werdna
Status:ok
Tags:
Comment:
Fix selectorother automatic addition of "other" field -- not switched over for the switching of keys/values
Modified paths:
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLForm.php
@@ -581,7 +581,7 @@
582582
583583 function __construct( $params ) {
584584 if (! array_key_exists('other', $params['options']) ) {
585 - $params['options']['other'] = wfMsg( 'htmlform-selectorother-other' );
 585+ $params['options'][wfMsg( 'htmlform-selectorother-other' )] = 'other';
586586 }
587587
588588 parent::__construct( $params );

Status & tagging log