r49806 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r49805
|
r49806
|
r49807
>
Date:
08:58, 24 April 2009
Author:
werdna
Status:
ok
Tags:
Comment:
Update HTMLSelectOrOtherField to correctly work, since the code changes of having "nested" options and swapping keys and values
Modified paths:
/trunk/phase3/includes/HTMLForm.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/HTMLForm.php
—
—
@@ -591,7 +591,8 @@
592
592
593
593
$valInSelect = false;
594
594
if ($value !== false)
595
- $valInSelect = array_key_exists( $value, $this->mParams['options'] );
595
+ $valInSelect = in_array( $value,
596
+ HTMLFormField::flattenOptions($this->mParams['options']) );
596
597
597
598
$selected = $valInSelect ? $value : 'other';
598
599
Status & tagging log
07:34, 22 May 2009
Tim Starling
(
talk
|
contribs
)
changed the
status
of r49806
[
removed:
new
added:
ok]
18:37, 28 April 2009
Brion VIBBER
(
talk
|
contribs
)
changed the
status
of r49806
[
removed:
new
added:
ok]