r49778 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49777‎ | r49778 | r49779 >
Date:17:55, 23 April 2009
Author:ialex
Status:deferred
Tags:
Comment:
Call Skin::setTitle() in 1.15+ so that it doesn't throw E_ERROR when using $this->mTitle in Skin
Modified paths:
  • /trunk/extensions/SkinPerNamespace/SkinPerNamespace.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SkinPerNamespace/SkinPerNamespace.php
@@ -47,8 +47,11 @@
4848 return true;
4949
5050 $ns = $wgTitle->getNamespace();
51 - if( isset( $wgSkinPerNamespace[$ns] ) )
 51+ if( isset( $wgSkinPerNamespace[$ns] ) ) {
5252 $skin = Skin::newFromKey( $wgSkinPerNamespace[$ns] );
 53+ if( is_callable( array( $skin, 'setTitle' ) ) ) # 1.15 +
 54+ $skin->setTitle( $out->getTitle() );
 55+ }
5356
5457 return true;
5558 }

Status & tagging log