r49755 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49754‎ | r49755 | r49756 >
Date:04:20, 23 April 2009
Author:nad
Status:deferred
Tags:
Comment:
editdate must be calculated inside loop
Modified paths:
  • /trunk/extensions/CategoryWatch/CategoryWatch.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryWatch/CategoryWatch.php
@@ -143,10 +143,10 @@
144144 $page = $title->getPrefixedText();
145145 $adminAddress = new MailAddress( $wgPasswordSender, 'WikiAdmin' );
146146 $editorAddress = new MailAddress( $editor );
147 - $timecorrection = $watchingUser->getOption( 'timecorrection' );
148 - $editdate = $wgLang->timeanddate( wfTimestampNow(), true, false, $timecorrection );
149147 foreach ( $res as $row ) {
150 - $watchingUser = User::newFromId( $row->wl_user );
 148+ $watchingUser = User::newFromId( $row->wl_user );
 149+ $timecorrection = $watchingUser->getOption( 'timecorrection' );
 150+ $editdate = $wgLang->timeanddate( wfTimestampNow(), true, false, $timecorrection );
151151 if ( $watchingUser->getOption( 'enotifwatchlistpages' ) && $watchingUser->isEmailConfirmed() ) {
152152
153153 $to = new MailAddress( $watchingUser );

Status & tagging log