r49665 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49664‎ | r49665 | r49666 >
Date:16:13, 20 April 2009
Author:demon
Status:ok
Tags:
Comment:
Use getTitle(), since mTitle is now protected.
Modified paths:
  • /trunk/extensions/Collection/Collection.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.hooks.php
@@ -40,8 +40,8 @@
4141 $action = $wgRequest->getVal('action');
4242
4343 if ( $skinTemplate->iscontent && ( $action == '' || $action == 'view' || $action == 'purge' ) ) {
44 - if ( self::_isCollectionPage( $skinTemplate->mTitle, $wgArticle ) ) {
45 - $params = 'colltitle=' . wfUrlencode( $skinTemplate->mTitle->getPrefixedDBKey() );
 44+ if ( self::_isCollectionPage( $skinTemplate->getTitle(), $wgArticle ) ) {
 45+ $params = 'colltitle=' . wfUrlencode( $skinTemplate->getTitle()->getPrefixedDBKey() );
4646 if ( isset( $wgCollectionFormats['rl'] ) ) {
4747 $nav_urls['printable_version_pdf'] = array(
4848 'href' => SkinTemplate::makeSpecialUrlSubpage(
@@ -54,7 +54,7 @@
5555 foreach ( $wgCollectionFormats as $writer => $name ) {
5656 }
5757 } else {
58 - $params = 'arttitle=' . $skinTemplate->mTitle->getPrefixedURL();
 58+ $params = 'arttitle=' . $skinTemplate->getTitle()->getPrefixedURL();
5959 if( $wgArticle ) {
6060 $oldid = $wgArticle->getOldID();
6161 if ( $oldid ) {

Status & tagging log