r49628 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49627‎ | r49628 | r49629 >
Date:17:05, 18 April 2009
Author:dale
Status:deferred
Tags:
Comment:
fixed php open tags for better compatibility
Modified paths:
  • /trunk/extensions/MetavidWiki/skins/mv_embed/example_usage/sample_page.php (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/example_usage/sample_playlists.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/skins/mv_embed/example_usage/sample_page.php
@@ -22,7 +22,7 @@
2323 Your embed type has been detected as: <b><span id="detect_type"></span></b>
2424 <br />
2525 Here are some sample embeds:<br />
26 -<?
 26+<?php
2727 $sample_embed = array();
2828
2929 $sample_embed[0]['tag'] = '<video id="embed_vid"
@@ -81,19 +81,19 @@
8282
8383 ?>
8484 <table border="1" cellpadding="6" width="600">
85 - <? foreach ( $sample_embed as $key => $aval ) {
 85+ <?php foreach ( $sample_embed as $key => $aval ) {
8686 // $key!=8 && $key!=3 $key != 0 && $key != 1 && && $key!=3
8787 if ( $key!=0 && $key!=8 )continue;
8888 ?>
8989 <tr>
90 - <td valign="top"><?=$aval['tag']?></td>
91 - <td valign="top"><b>Sample Embed <?=$key?></b><br />
92 - <?=$aval['desc']?><br />
 90+ <td valign="top"><?php echo $aval['tag']?></td>
 91+ <td valign="top"><b>Sample Embed <?php echo $key?></b><br />
 92+ <?php echo $aval['desc'] ?><br />
9393 &lt;-- code used: <br />
94 - <pre> <?= htmlentities( $aval['tag'] )?></pre>
 94+ <pre> <?php echo htmlentities( $aval['tag'] )?></pre>
9595 </td>
9696 </tr>
97 - <? // oput a separator between video and playlist
 97+ <?php // oput a separator between video and playlist
9898 if ( $key == 5 ) {
9999 echo '<tr><td colspan="2"><b>Sample Playlists:</b></td></tr>';
100100 }
@@ -102,6 +102,6 @@
103103 <br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br />&nbsp;
104104 </body>
105105 </html>
106 -<?
 106+<?php
107107 }
108108 ?>
\ No newline at end of file
Index: trunk/extensions/MetavidWiki/skins/mv_embed/example_usage/sample_playlists.php
@@ -61,19 +61,19 @@
6262
6363 ?>
6464 <table border="1" cellpadding="6" width="600">
65 - <? foreach ( $sample_embed as $key => $aval ) {
 65+ <?php foreach ( $sample_embed as $key => $aval ) {
6666 // &&
6767 if ( $key != 9 && $key != 8 && $key !=4)continue;
6868 ?>
6969 <tr>
70 - <td valign="top"><?=$aval['tag']?></td>
71 - <td valign="top"><b>Sample Embed <?=$key?></b><br />
72 - <?=$aval['desc']?><br />
 70+ <td valign="top"><?php echo $aval['tag']?></td>
 71+ <td valign="top"><b>Sample Embed <?php echo $key?></b><br />
 72+ <?php echo $aval['desc']?><br />
7373 &lt;-- code used: <br />
74 - <pre> <?= htmlentities( $aval['tag'] )?></pre>
 74+ <pre> <?php echo htmlentities( $aval['tag'] )?></pre>
7575 </td>
7676 </tr>
77 - <? // oput a separator between video and playlist
 77+ <?php // oput a separator between video and playlist
7878 if ( $key == 5 ) {
7979 echo '<tr><td colspan="2"><b>Sample Playlists:</b></td></tr>';
8080 }
@@ -82,6 +82,6 @@
8383 <br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br />&nbsp;
8484 </body>
8585 </html>
86 -<?
 86+<?php
8787 }
8888 ?>

Status & tagging log