r49587 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49586‎ | r49587 | r49588 >
Date:23:49, 16 April 2009
Author:tparscal
Status:deferred
Tags:
Comment:
RTL friendly alignment!
Modified paths:
  • /trunk/extensions/Drafts/Drafts.classes.php (modified) (history)
  • /trunk/extensions/Drafts/Drafts.css (modified) (history)

Diff [purge]

Index: trunk/extensions/Drafts/Drafts.classes.php
@@ -200,20 +200,13 @@
201201 $wgOut->addHTML( Xml::openElement( 'tr' ) );
202202 $wgOut->addHTML(
203203 Xml::element( 'th',
204 - array(
205 - 'align' => 'left',
206 - 'width' => '75%',
207 - 'nowrap' => 'nowrap'
208 - ),
 204+ array( 'width' => '75%', 'nowrap' => 'nowrap' ),
209205 wfMsg( 'drafts-view-article' )
210206 )
211207 );
212208 $wgOut->addHTML(
213209 Xml::element( 'th',
214 - array(
215 - 'align' => 'left',
216 - 'nowrap' => 'nowrap'
217 - ),
 210+ array( 'nowrap' => 'nowrap' ),
218211 wfMsg( 'drafts-view-saved' )
219212 )
220213 );
@@ -260,12 +253,7 @@
261254 // Build XML
262255 $wgOut->addHTML( Xml::openElement( 'tr' ) );
263256 $wgOut->addHTML(
264 - Xml::openElement( 'td',
265 - array(
266 - 'align' => 'left',
267 - 'nowrap' => 'nowrap'
268 - )
269 - )
 257+ Xml::openElement( 'td', array( 'nowrap' => 'nowrap' ) )
270258 );
271259 $wgOut->addHTML(
272260 Xml::element( 'a',
@@ -283,19 +271,13 @@
284272 $wgOut->addHTML( Xml::closeElement( 'td' ) );
285273 $wgOut->addHTML(
286274 Xml::element( 'td',
287 - array(
288 - 'align' => 'left',
289 - 'nowrap' => 'nowrap'
290 - ),
 275+ array( 'nowrap' => 'nowrap' ),
291276 $wgLang->timeanddate( $draft->getSaveTime() )
292277 )
293278 );
294279 $wgOut->addHTML(
295280 Xml::openElement( 'td',
296 - array(
297 - 'align' => 'left',
298 - 'nowrap' => 'nowrap'
299 - )
 281+ array( 'nowrap' => 'nowrap' )
300282 )
301283 );
302284 $jsClick = "if( wgDraft.getState() !== 'unchanged' )" .
Index: trunk/extensions/Drafts/Drafts.css
@@ -10,4 +10,12 @@
1111 #drafts-list-table {
1212 margin-left: -5px;
1313 margin-right:-5px;
 14+}
 15+
 16+#drafts-list-table td, #drafts-list-table th {
 17+ text-align: left;
 18+}
 19+
 20+.rtl #drafts-list-table td, .rtl #drafts-list-table th {
 21+ text-align: right;
1422 }
\ No newline at end of file

Status & tagging log