r49585 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49584‎ | r49585 | r49586 >
Date:23:30, 16 April 2009
Author:siebrand
Status:deferred
Tags:
Comment:
(bug 18083) Fatal errors in UserRightsNotif
Fixed by using correct globals.
Modified paths:
  • /trunk/extensions/UserRightsNotif/UserRightsNotif.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UserRightsNotif/UserRightsNotif.php
@@ -34,11 +34,11 @@
3535 }
3636
3737 function efUserRightsNotifier( &$user, $added, $removed ) {
38 - global $wgUserRightsNotif, $wgContentLang;
 38+ global $wgUserRightsNotif;
3939 if( $user->canReceiveEmail() ) {
4040 global $wgUser, $wgSitename, $wgContLang;
41 - $added = is_array( $added ) ? $wgContentLang->commaList( $added ) : '';
42 - $removed = is_array( $removed ) ? $wgContentLang->commaList( $removed ) : '';
 41+ $added = is_array( $added ) ? $wgContLang->commaList( $added ) : '';
 42+ $removed = is_array( $removed ) ? $wgContLang->commaList( $removed ) : '';
4343 $subject = wfMsg( 'userrightsnotifysubject', $wgSitename );
4444 $message = wfMsg( 'userrightsnotifybody', $user->getName(), $wgSitename, $wgUser->getName(), $wgContLang->timeAndDate( wfTimestampNow() ), $added, $removed );
4545 $user->sendMail( $subject, $message, $wgUserRightsNotif['sender'] );

Status & tagging log