r49440 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49439‎ | r49440 | r49441 >
Date:12:39, 13 April 2009
Author:demon
Status:ok
Tags:accessibility 
Comment:
(bug 18317) Bolded selections in 1 | 3 | etc days on RecentChanges now use <strong> instead of hardcoded styles. Based on patch by jidanni.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -597,8 +597,12 @@
598598 global $wgUser;
599599 $sk = $wgUser->getSkin();
600600 $params = $override + $options;
601 - return $sk->link( $this->getTitle(), htmlspecialchars( $title ),
602 - ( $active ? array( 'style'=>'font-weight: bold;' ) : array() ), $params, array( 'known' ) );
 601+ if ( $active ) {
 602+ return $sk->link( $this->getTitle(), '<strong>' . htmlspecialchars( $title ) . '</strong>',
 603+ array(), $params, array( 'known' ) );
 604+ } else {
 605+ return $sk->link( $this->getTitle(), htmlspecialchars( $title ), array() , $params, array( 'known' ) );
 606+ }
603607 }
604608
605609 /**
Index: trunk/phase3/RELEASE-NOTES
@@ -343,6 +343,8 @@
344344 * Fixed a bug caused by LanguageConverter.php, which brings an abnormal '}-'
345345 after some parsed math syntax.
346346 * (bug 18441) rebuildrecentchanges.inc no longer ignores $wgLogRestrictions
 347+* (bug 18317) Bolded selections in 1 | 3 | etc days on RecentChanges now use
 348+ <strong> instead of hardcoded styles
347349
348350 == API changes in 1.15 ==
349351 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Status & tagging log