r49424 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49423‎ | r49424 | r49425 >
Date:14:55, 12 April 2009
Author:aaron
Status:ok
Tags:
Comment:
Minor JS fix for r49408
Modified paths:
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -431,7 +431,8 @@
432432 }
433433 for (var i = start; i <= finish; ++i ) {
434434 checkboxes[i].checked = endState;
435 - if( i > start ) checkboxes[i].onchange(); // fire triggers
 435+ if( i > start && typeof checkboxes[i].onchange == 'function' )
 436+ checkboxes[i].onchange(); // fire triggers
436437 }
437438 lastCheckbox = this.index;
438439 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49408(bug 16607) Added convenience checkboxes for revisiondelete to history pagesaaron17:38, 11 April 2009

Status & tagging log