r49414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49413‎ | r49414 | r49415 >
Date:23:05, 11 April 2009
Author:aaron
Status:ok
Tags:
Comment:
Removed $wgTitle from PageHistory
Modified paths:
  • /trunk/phase3/includes/PageHistory.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
@@ -1528,11 +1528,11 @@
15291529 $s = '';
15301530 $changes = self::getChanges( $nbitfield, $obitfield );
15311531 if( count( $changes[0] ) ) {
1532 - $s .= wfMsgForContent ( 'revdelete-hid', implode ( ', ', $changes[0] ) );
 1532+ $s .= wfMsgForContent( 'revdelete-hid', implode( ', ', $changes[0] ) );
15331533 }
15341534 if( count( $changes[1] ) ) {
15351535 if ($s) $s .= '; ';
1536 - $s .= wfMsgForContent ( 'revdelete-unhid', implode ( ', ', $changes[1] ) );
 1536+ $s .= wfMsgForContent( 'revdelete-unhid', implode( ', ', $changes[1] ) );
15371537 }
15381538 if( count( $changes[2] ) ) {
15391539 $s .= $s ? ' (' . $changes[2][0] . ')' : $changes[2][0];
Index: trunk/phase3/includes/PageHistory.php
@@ -67,7 +67,7 @@
6868 * @returns nothing
6969 */
7070 function history() {
71 - global $wgOut, $wgRequest, $wgTitle, $wgScript;
 71+ global $wgOut, $wgRequest, $wgScript;
7272
7373 /*
7474 * Allow client caching.
@@ -153,7 +153,7 @@
154154 * @return string HTML output
155155 */
156156 function beginHistoryList() {
157 - global $wgTitle, $wgUser, $wgScript, $wgEnableHtmlDiff;
 157+ global $wgUser, $wgScript, $wgEnableHtmlDiff;
158158 $this->lastdate = '';
159159 $s = wfMsgExt( 'histlegend', array( 'parse') );
160160 if( $wgUser->isAllowed('deleterevision') ) {
@@ -165,14 +165,14 @@
166166 'style' => 'visibility:hidden;float:right;'
167167 )
168168 );
169 - $s .= Xml::hidden( 'target', $wgTitle->getPrefixedDbKey() );
 169+ $s .= Xml::hidden( 'target', $this->mTitle->getPrefixedDbKey() );
170170 $s .= Xml::hidden( 'oldid', '', array('id'=>'revdel-oldid') );
171171 $s .= Xml::submitButton( wfMsg( 'showhideselectedversions' ) );
172172 $s .= Xml::closeElement( 'form' );
173173 }
174174 $s .= Xml::openElement( 'form', array( 'action' => $wgScript,
175175 'id' => 'mw-history-compare' ) );
176 - $s .= Xml::hidden( 'title', $wgTitle->getPrefixedDbKey() );
 176+ $s .= Xml::hidden( 'title', $this->mTitle->getPrefixedDbKey() );
177177 if( $wgEnableHtmlDiff ) {
178178 $s .= $this->submitButton( wfMsg( 'visualcomparison'),
179179 array(

Status & tagging log