r49359 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49358‎ | r49359 | r49360 >
Date:23:38, 9 April 2009
Author:rememberthedot
Status:ok
Tags:
Comment:
Follow-up to r49350, corrected code to follow coding conventions for braces and variable names
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -373,11 +373,10 @@
374374 <?php
375375 }
376376
377 - private function langAttributes()
378 - {
 377+ private function langAttributes() {
379378 global $wgLang;
380 - $wgLangCode = $wgLang->getCode();
381 - return 'lang="' . $wgLangCode . '" xml:lang="' . $wgLangCode . '"';
 379+ $languageCode = $wgLang->getCode();
 380+ return 'lang="' . $languageCode . '" xml:lang="' . $languageCode . '"';
382381 }
383382 } // end of class
384383

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49350Follow-up to r49331, reduce redundancy in language attribute generation in Mo...rememberthedot19:06, 9 April 2009

Status & tagging log