r49334 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49333‎ | r49334 | r49335 >
Date:10:28, 9 April 2009
Author:ialex
Status:ok
Tags:
Comment:
fix variable collision introduced in r49324
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -528,10 +528,10 @@
529529 # from request values or be specified in "sub page" form. The plot
530530 # thickens, because $wgTitle is altered for special pages, so doesn't
531531 # contain the original alias-with-subpage.
532 - $title = Title::newFromText( $wgRequest->getText( 'title' ) );
533 - if( $title instanceof Title && $title->getNamespace() == NS_SPECIAL ) {
 532+ $origTitle = Title::newFromText( $wgRequest->getText( 'title' ) );
 533+ if( $origTitle instanceof Title && $origTitle->getNamespace() == NS_SPECIAL ) {
534534 list( $spName, $spPar ) =
535 - SpecialPage::resolveAliasWithSubpage( $title->getText() );
 535+ SpecialPage::resolveAliasWithSubpage( $origTitle->getText() );
536536 $active = $spName == 'Contributions'
537537 && ( ( $spPar && $spPar == $this->username )
538538 || $wgRequest->getText( 'target' ) == $this->username );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49324Stage 2 of war on $wgTitle!! Make OutputPage, Skin and children rely on mTitl...demon02:22, 9 April 2009

Status & tagging log